Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frontend API policy #71

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Fix frontend API policy #71

merged 1 commit into from
Mar 14, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Mar 14, 2024 •
edited
Loading

🗣 Description

We found a typo in the unauthenticated API policy (extra single-quote).

💭 Motivation and context

Causing errors accessing the API.

🧪 Testing

Passes checks.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@aloftus23 aloftus23 added the bug This issue or pull request addresses broken functionality label Mar 14, 2024
@aloftus23 aloftus23 self-assigned this Mar 14, 2024
@aloftus23 aloftus23 marked this pull request as ready for review March 14, 2024 16:26
Matthew-Grayson
Matthew-Grayson approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@schmelz21 schmelz21 merged commit 0c76b7a into develop Mar 14, 2024
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmelz21 schmelz21 schmelz21 approved these changes

@Matthew-Grayson Matthew-Grayson Matthew-Grayson approved these changes

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

Assignees

@aloftus23 aloftus23

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloftus23 @schmelz21 @Matthew-Grayson