Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update User list functionality and design in Users.tsx #83

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Mar 15, 2024

🗣 Description

Update the Manage Users's page to display all Users in a paginated table view similar to the new Organizations table. Additional functionality may be applied to enhance the user experience.

💭 Motivation and context

Improves user experience and adds functionality.

🧪 Testing

Display is different and functionality works as intended.

📷 Screenshots (if appropriate)

Current unpaginated users table and rest of the page
old_crossfeed_users_table
image

Updated paginated users table and rest of the page
new_crossfeed_users_page

Updated pop up to invite a new user and form validation
image
image

Updated confirmation before deleting a user
image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav marked this pull request as ready for review March 15, 2024 18:35
@ameliav ameliav self-assigned this Mar 15, 2024
@ameliav ameliav linked an issue Mar 15, 2024 that may be closed by this pull request
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 2d1781a into develop Mar 19, 2024
9 of 14 checks passed
@ameliav ameliav deleted the 42-ui-redesign-users-list branch March 20, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Redesign Users List
4 participants