Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #77

Merged
merged 137 commits into from
Apr 24, 2024
Merged

Commits on Sep 13, 2023

  1. Bump crazy-max/ghaction-github-status from 3 to 4

    Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4.
    - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases)
    - [Commits](crazy-max/ghaction-github-status@v3...v4)
    
    ---
    updated-dependencies:
    - dependency-name: crazy-max/ghaction-github-status
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Sep 13, 2023
    Configuration menu
    Copy the full SHA
    b5e5c11 View commit details
    Browse the repository at this point in the history
  2. Add a diagnostics job for the label syncing workflow

    Also add a runner hardening task to the labeler job.
    jsf9k committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    371179e View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Make the dev team the owners of the linter configuration files

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1f611fc View commit details
    Browse the repository at this point in the history
  2. Make dev team members the codeowners of the requirements*.txt and set…

    …up-env files
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    c356768 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Explicitly list the linter config files the dev team should own

    @mcdonnnj correctly pointed out that other projects add their own
    configuration files that match, e.g., the /.*.yaml pattern.  We want
    to ensure that we only own the linter configuration files from the
    skeleton.
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0195005 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Add a diagnostics job to the CodeQL workflow

    The CodeQL workflow already had a harden-runner task, but it's good to
    agree everywhere with the changes we made to the build.yml workflow in
    cisagov/skeleton-generic#144.
    jsf9k committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2e30384 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Bump hashicorp/setup-terraform from 2 to 3

    Bumps [hashicorp/setup-terraform](https://github.com/hashicorp/setup-terraform) from 2 to 3.
    - [Release notes](https://github.com/hashicorp/setup-terraform/releases)
    - [Changelog](https://github.com/hashicorp/setup-terraform/blob/main/CHANGELOG.md)
    - [Commits](hashicorp/setup-terraform@v2...v3)
    
    ---
    updated-dependencies:
    - dependency-name: hashicorp/setup-terraform
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b768a28 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Remove mention of collections from comment

    ansible-galaxy does not appear to allow roles to depend on
    collections.  See here for more details:
    cisagov/skeleton-ansible-role#153 (comment)
    jsf9k committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    05771a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Prefer block style to flow style

    We prefer block style to flow style for sequences and mappings in YAML.
    mcdonnnj committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9f31700 View commit details
    Browse the repository at this point in the history
  2. Alphabetize entries in the build workflow

    We prefer to alphabetize mapping keys in YAML documents whenever
    possible.
    mcdonnnj committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    696433a View commit details
    Browse the repository at this point in the history
  3. Add a merge_group trigger to the build workflow

    This should improve compatibility with merge queues. We configure it to
    only trigger on the `checks_requested` type which is currently the only
    supported type for this trigger. If additional types are added in the
    future they should be added if appropriate.
    mcdonnnj committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    6503a9e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Configuration menu
    Copy the full SHA
    74f2025 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Bump actions/setup-go from 4 to 5

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    193e799 View commit details
    Browse the repository at this point in the history
  2. Bump actions/setup-python from 4 to 5

    Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
    - [Release notes](https://github.com/actions/setup-python/releases)
    - [Commits](actions/setup-python@v4...v5)
    
    ---
    updated-dependencies:
    - dependency-name: actions/setup-python
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    5c84295 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Bump github/codeql-action from 2 to 3

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@v2...v3)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    2be8f7a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Switch pre-commit hooks for running shfmt

    This hook bundles the binaries for shfmt with a Python package which
    removes the need to manually install the tool for the hook to function.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    4a63dbe View commit details
    Browse the repository at this point in the history
  2. Remove installation of shfmt in the build workflow

    The new pre-commit hook provides `shfmt` binaries so we no longer need
    to ensure it is installed.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3236b1b View commit details
    Browse the repository at this point in the history
  3. Use long options for shfmt arguments

    Since shfmt now supports long command line options we should use them
    as that is our preference. The single quotes for the number of spaces
    to indent is changed to double quotes to align with our usual quotation
    style.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    5ddb14d View commit details
    Browse the repository at this point in the history
  4. Add additional shfmt options

    These options are baked into the functionality of the old hook but must
    be explicitly declared for the new hook.
    mcdonnnj committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    8ecd957 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Set the default shell for all run steps in the build workflow

    This sets the default shell for any run steps in the build workflow to
    mirror our standard shellscript writing practices. In addition to
    enabling our standard options it will also enable errtrace and print
    any commands that are run which should make debugging/troubleshooting
    more straightforward.
    mcdonnnj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    242921b View commit details
    Browse the repository at this point in the history
  2. Add linting with goimports to the pre-commit configuration

    This will run the Go tool `goimports` against the repository if it
    contains any Go files. This tool bundles the functionality of `go fmt`
    with the additional benefit of sorting Go imports much like the isort
    tool we use for Python code.
    mcdonnnj committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    c7b18dc View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Add ATX Header Support for terraform-docs

    This is a temporary fix until @mcdonnnj has
    his PR approved and merged into the terraform-docs
    repo. This fix will perform a shallow clone of his
    forked branch, build the binary, and install it.
    Michael Saki committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f6d9d6e View commit details
    Browse the repository at this point in the history
  2. Add prepended names to variables to describe their function

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    544e478 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary capitalizations and fix grammar

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    f5fa0ff View commit details
    Browse the repository at this point in the history
  4. Simplify steps in the build/install portion of workflow

    PATH is handled by `setup-go` so we can refactor the code setting it. Also we are taking advantage of the -C switch to handle building from the cloned repository.
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Jan 22, 2024
    Configuration menu
    Copy the full SHA
    36361dd View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Add TODO label

    michaelsaki authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    3711ebe View commit details
    Browse the repository at this point in the history
  2. Move TODO and add link to the issue

    `TODO` was placed on the wrong comment block. Also I am adding a link to the issue for the TODO.
    michaelsaki authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d114fb4 View commit details
    Browse the repository at this point in the history
  3. Alphabetize switches

    Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
    michaelsaki and dav3r authored Jan 23, 2024
    Configuration menu
    Copy the full SHA
    c907cfc View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Allow setup-env to specify Python version

    This commit is introducing 2 new flags
    into the setup-env script. -l or
    --list-versions will list available
    Python versions and allow the user to
    select a version interactively. The second
    flag -v or --version will allow a user
    to set the version if installed.
    (e.g. ./setup-env -v 3.9.6)
    Michael Saki committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    48db3e3 View commit details
    Browse the repository at this point in the history
  2. Add /dev/null and remove TMPFILE

    This makes the code a bit cleaner and still accomplishes the same functionality
    
    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    c10929a View commit details
    Browse the repository at this point in the history
  3. Place flags in the correct order for -r and -p

    Michael Saki committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    adada40 View commit details
    Browse the repository at this point in the history
  4. Remove unneccessary spacing

    Michael Saki committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    1861b9b View commit details
    Browse the repository at this point in the history
  5. Alphabetize flags and descriptions

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    3f623e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Move misplaced exit

    If the Python version exists then we want the script to continue
    execution.
    jsf9k committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9497dc2 View commit details
    Browse the repository at this point in the history
  2. Remove premature pyenv local command

    pyenv local is run below.
    jsf9k committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    e1d0f28 View commit details
    Browse the repository at this point in the history
  3. Include PYTHON_VERSION when running pyenv virtualenv

    If PYTHON_VERSION is an empty string then the system Python will be used.
    jsf9k committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    517b336 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Add getopt variables and short flags

    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2e5794c View commit details
    Browse the repository at this point in the history
  2. Remove redundant flag initialization

    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    8a50031 View commit details
    Browse the repository at this point in the history
  3. Add getopt functionality and -n flag

    This commit makes a couple changes. The first
    change is adding the BSD getopt tool to
    simplify the parsing of flags and arguments.
    Second, we are adding the -n flag so the user
    can specify the name of the virtual environment
    if they choose.
    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0df0e6a View commit details
    Browse the repository at this point in the history
  4. Update the usage and force documentation

    This commit will update the usage documentation
    so now it will display all the new flags, how
    to use them, and what they do. Since the
    long option isn't available for the BSD version
    of getopt we have to use short options only.
    The force documentation has been updated to
    reflect this change. Also removed some redundant
    code that wasn't necessary.
    Michael Saki committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    60cad12 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Update usage with long options

    Michael Saki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    b6ab6d8 View commit details
    Browse the repository at this point in the history
  2. Add gnu-getopt functionality and error handling

    This commit will make it so long options are
    supported. It also includes some improved
    error handling. It will display a message if
    a Mac OS user doesn't have gnu-getopt installed
    on their system and suggest steps to take to
    get it installed via brew.
    Michael Saki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d362614 View commit details
    Browse the repository at this point in the history
  3. Add documentation in CONTRIBUTING.md for gnu-getopt

    Michael Saki committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f924584 View commit details
    Browse the repository at this point in the history
  4. Fix grammar and capitalization errors

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ba86ead View commit details
    Browse the repository at this point in the history
  5. Combine PATH exports to single line

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    ba0fc19 View commit details
    Browse the repository at this point in the history
  6. Improve usage instructions

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    1240bdd View commit details
    Browse the repository at this point in the history
  7. Add $(brew --prefix) to PATH for getopt

    Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
    michaelsaki and dav3r authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    297b5bd View commit details
    Browse the repository at this point in the history
  8. Fix confusing wording

    Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
    michaelsaki and dav3r authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7af70f5 View commit details
    Browse the repository at this point in the history
  9. Replace virt_env_name w/ virtual_env_name for clarity

    Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
    michaelsaki and dav3r authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    e5a2d14 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Differentiate between GNU getopt and gnu-getopt brew formula

    This commit will clearly differentiate between GNU getopt the tool and gnu-getopt the Homebrew formula. Also updating the URL so that getopt points at the source repository and pyenv and pyenv-virtualenv point at their respective repositories. Updated the ending punctuation.
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    82c70e0 View commit details
    Browse the repository at this point in the history
  2. Add parenthesis over brew link

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 13, 2024
    Configuration menu
    Copy the full SHA
    493a4a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Refactor flag names for clarity and accuracy

    This commit will remove the previous flags
    -v or --version for -p or --python-version.
    Also it will replace -n or --name for -v or
    --venv-name. The usage menu has been updated
    to reflect these changes as well.
    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    3bc9aeb View commit details
    Browse the repository at this point in the history
  2. Elaborate on message when checking for GNU getopt

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0be1f63 View commit details
    Browse the repository at this point in the history
  3. Remove unnecessary nounset flipping logic

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    c8f0b1b View commit details
    Browse the repository at this point in the history
  4. Separate pyenv PATH from GNU getopt PATH

    Michael Saki committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    495862a View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Improve verbiage in comments

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    4752b37 View commit details
    Browse the repository at this point in the history
  2. Clarify between pyenv and GNU getopt setup

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    2e38997 View commit details
    Browse the repository at this point in the history
  3. Improve comment on conditional check for regex

    Michael Saki committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    f8824c8 View commit details
    Browse the repository at this point in the history
  4. Add comment explaining that GNU getopt is keg-only

    Michael Saki committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    88724e7 View commit details
    Browse the repository at this point in the history
  5. Improve comments to better describe keg-only terminology

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Feb 21, 2024
    Configuration menu
    Copy the full SHA
    c1870be View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Change "'setup-env' tool" to "'setup-env' script"

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a3f69cd View commit details
    Browse the repository at this point in the history
  2. Remove build-in error exit for generic error exit

    Exit code 2 usually relates to build-ins which does not fit what is failing here. Not sure what alternative would be best so we can just use the generic failure code
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    8ff5179 View commit details
    Browse the repository at this point in the history
  3. Change verbiage from 'tool' to 'script' for clarity

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1c21e2b View commit details
    Browse the repository at this point in the history
  4. Check for pyenv earlier in the script

    Since the new function, python_versions expects
    pyenv to be installed it makes sense to have it
    checked earlier in the script.
    Michael Saki committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3acc8d6 View commit details
    Browse the repository at this point in the history
  5. Explain -r and -p in Python version prompt

    Michael Saki committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    b377ce7 View commit details
    Browse the repository at this point in the history
  6. Refine exit code to 64 with gnu-getopt note

    - Set exit code to 64 per sysexits.h for clarity.
    - Added comment on gnu-getopt handling.
    
    Aligns with Unix standards and enhances readability.
    Michael Saki committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    74838a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Rename gnu-getopt tool to GNU getopt formula

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    487126e View commit details
    Browse the repository at this point in the history
  2. Fix whitespace for usage menu

    Co-authored-by: Shane Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
    michaelsaki and jsf9k authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6c82a8d View commit details
    Browse the repository at this point in the history
  3. Add link to brew terminology

    Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
    michaelsaki and dav3r authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    324f6d4 View commit details
    Browse the repository at this point in the history
  4. Rephrase comment to improve clarity

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    a26d0e3 View commit details
    Browse the repository at this point in the history
  5. Improve comment for clarity

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0510870 View commit details
    Browse the repository at this point in the history
  6. Improve verbiage in comment

    Michael Saki committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    01abde6 View commit details
    Browse the repository at this point in the history
  7. Change comments for macOS and venv_name

    Michael Saki committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0989d17 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. Improve comments for clarity

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    michaelsaki and mcdonnnj authored Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a9c6ed8 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Configuration menu
    Copy the full SHA
    e58dde5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    292b0c3 View commit details
    Browse the repository at this point in the history
  3. Allow ansible versions greater than 6

    Ansible 9 appears to function without issue.
    
    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    d8b06f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. Remove comment that is now unnecessary

    Co-authored-by: Michael Saki <michael.saki@associates.cisa.dhs.gov>
    jsf9k and Michael Saki committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    02e1530 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Use the full path for source Docker images

    This ensures that when a Docker image is pulled for molecule's testing
    the expected source image is used regardless of what registry is
    configured as the default on the host system. This will also make it
    trivial to convert to using the GitHub Container Registry or any other
    Open Container Initiative (OCI) container registry for source images.
    mcdonnnj committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0f82722 View commit details
    Browse the repository at this point in the history
  2. Update pre-commit hook versions

    This is done automatically with the `pre-commit autoupdate` command.
    The pre-commit/mirrors-prettier was manually held back because the
    latest tags are for alpha releases of the next major version.
    mcdonnnj committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    b9c729f View commit details
    Browse the repository at this point in the history
  3. Manually update the prettier hook

    The hook is manually updated to the last v3 tag available from the
    pre-commit/mirrors-prettier repository. We then add the latest release
    of v3 available from NPM as an additional depdency.
    mcdonnnj committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4c93395 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Merge pull request #149 from cisagov/dependabot/github_actions/crazy-…

    …max/ghaction-github-status-4
    
    Bump crazy-max/ghaction-github-status from 3 to 4
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9a0e7c3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #150 from cisagov/improvement/add-diagnostics-to-l…

    …abel-sync-workflow
    
    Add a diagnostics job for the label syncing workflow
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d0d8783 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #151 from cisagov/improvement/make-ois-own-linting…

    …-configs
    
    Make the dev team the owners of the linter configuration files
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    158abf5 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #155 from cisagov/dependabot/github_actions/hashic…

    …orp/setup-terraform-3
    
    Bump hashicorp/setup-terraform from 2 to 3
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    6f23c97 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #156 from cisagov/improvement/better_support_merge…

    …_queues
    
    Improve merge queue support
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    c0043bd View commit details
    Browse the repository at this point in the history
  6. Merge pull request #158 from cisagov/dependabot/github_actions/action…

    …s/setup-go-5
    
    Bump actions/setup-go from 4 to 5
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e5ffc52 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #159 from cisagov/dependabot/github_actions/action…

    …s/setup-python-5
    
    Bump actions/setup-python from 4 to 5
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    59b2ad1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    57bef4a View commit details
    Browse the repository at this point in the history
  9. Merge pull request #162 from cisagov/improvement/set_default_for_run_…

    …steps
    
    Set the default `shell` for all `run` steps in the `build` workflow
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    01c9e11 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #166 from cisagov/improvement/allow_setup-env_to_s…

    …pecify_python
    
    Allow setup-env to specify Python version
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    d1a186d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7169dcf View commit details
    Browse the repository at this point in the history
  12. Merge pull request #157 from cisagov/improvement/get_more_versions_fr…

    …om_action
    
    Use `cisagov/setup-env-github-action` to provide the Python and Go versions to use
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    95a61f5 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #160 from cisagov/improvement/switch_pre-commit_ho…

    …ok_for_shfmt
    
    Switch the pre-commit hook used to run `shfmt`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    81735c2 View commit details
    Browse the repository at this point in the history
  14. Merge pull request #163 from cisagov/improvement/add_goimports_hook

    Add a pre-commit hook to run `goimports`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    4f73489 View commit details
    Browse the repository at this point in the history
  15. Merge pull request #164 from cisagov/improvement/install_atx_header_s…

    …upport_terraform-docs
    
    Add ATX Header Support for `terraform-docs`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9020b55 View commit details
    Browse the repository at this point in the history
  16. Switch pre-commit hooks for running shellcheck

    This hook bundles the binaries for shellcheck with a Python package
    which removes the need to ensure the tool is installed for the hook to
    function. It also ties the version of shellcheck used to the hook which
    will help guarantee consistency.
    mcdonnnj committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    035cf86 View commit details
    Browse the repository at this point in the history
  17. Merge pull request #168 from cisagov/improvement/switch_pre-commit_ho…

    …ok_for_shellcheck
    
    Switch the pre-commit hook used to run `shellcheck`
    mcdonnnj authored Mar 6, 2024
    Configuration menu
    Copy the full SHA
    e79569c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    b45e9cd View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    26a5154 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    88b5bc2 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Remove needless Dependabot ignore directive

    The pin against ansible-lint was removed in commit
    3299332, so there is no longer any
    need for the Dependabot ignore directive.
    jsf9k committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    3a41b57 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    48ed909 View commit details
    Browse the repository at this point in the history
  2. Add new, disabled dependabot ignore directive

    Add github/codeql-action to the github-actions ignore directives as it
    is used in the CodeQL workflow. It is commented out in this project and
    will be un-commented in downstream repositories so that only
    cisagov/skeleton-ansible-role will have dependabot PRs created for
    this dependency.
    mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    25fbe56 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #177 from cisagov/lineage/skeleton

    Lineage pull request for: skeleton
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f46945c View commit details
    Browse the repository at this point in the history
  4. Merge pull request #173 from cisagov/improvement/use-recent-version-o…

    …f-ansible
    
    Allow ansible versions greater than 6
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    680a61f View commit details
    Browse the repository at this point in the history
  5. Merge pull request #175 from cisagov/improvement/always-use-systemd-e…

    …nabled-images
    
    Always use systemd-enabled Docker images
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fc200bc View commit details
    Browse the repository at this point in the history
  6. Merge pull request #180 from cisagov/bugfix/remove-dependabot-ignore-…

    …directive
    
    Remove needless Dependabot ignore directive
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    78cbce3 View commit details
    Browse the repository at this point in the history
  7. Merge pull request #171 from cisagov/improvement/update_dependabot_ig…

    …nore_directives
    
    Add new, disabled dependabot ignore directive
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e86a3bc View commit details
    Browse the repository at this point in the history
  8. Pin ansible-core to earlier than 2.16.3

    ansible-core 2.16.3 and later suffer from the bug discussed in
    ansible/ansible#82702, which breaks any symlinked files in vars,
    tasks, etc. for any Ansible role installed via ansible-galaxy.
    jsf9k authored and mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    73cb512 View commit details
    Browse the repository at this point in the history
  9. Remove duplicated octothorpe

    Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
    2 people authored and mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    097026d View commit details
    Browse the repository at this point in the history
  10. Add a Dependabot ignore directive for downstream repository

    Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
    jsf9k and mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c61ebc7 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #179 from cisagov/bugfix/pin-ansible-core

    Pin `ansible-core` to earlier than 2.16.3
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    472b883 View commit details
    Browse the repository at this point in the history
  12. Merge pull request #170 from cisagov/dependabot/github_actions/github…

    …/codeql-action-3
    
    Bump github/codeql-action from 2 to 3
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2e055e0 View commit details
    Browse the repository at this point in the history
  13. Merge pull request #168 from cisagov/documentation/how-to-install-role

    Add a section describing how to install the role
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4fe777f View commit details
    Browse the repository at this point in the history
  14. Merge pull request #163 from cisagov/improvement/add-diagnostics-job-…

    …for-codeql-workflow
    
    Add a diagnostics job to the CodeQL workflow
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    508324d View commit details
    Browse the repository at this point in the history
  15. Merge pull request #165 from cisagov/documentation/no-collections-in-…

    …meta
    
    Remove mention of collections from comment
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    13a4fb2 View commit details
    Browse the repository at this point in the history
  16. Merge pull request #176 from cisagov/improvement/use_full_image_source

    Use the full path for source Docker images
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    d7a47a7 View commit details
    Browse the repository at this point in the history
  17. Add support for Debian Trixie

    jsf9k authored and mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9949fc8 View commit details
    Browse the repository at this point in the history
  18. Use a different image for Debian Bookworm testing

    Now that geerlingguy/docker-debian12-ansible is available we can switch
    to it instead of using ours.
    mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fb16c79 View commit details
    Browse the repository at this point in the history
  19. Remove the Fedora 37 platform

    Fedora 37 is EOL as of December 5, 2023.
    jsf9k authored and mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c116434 View commit details
    Browse the repository at this point in the history
  20. Add support for Fedora 39

    Fedora 39 was released on November 7, 2023.
    jsf9k authored and mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7cb7ddf View commit details
    Browse the repository at this point in the history
  21. Merge pull request #164 from cisagov/improvement/debian-bookworm-rele…

    …ased
    
    Add support for Debian Trixie
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    387a5e9 View commit details
    Browse the repository at this point in the history
  22. Merge pull request #166 from cisagov/feature/add-support-for-fedora-39

    Add support for Fedora 39
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    569d377 View commit details
    Browse the repository at this point in the history
  23. Merge pull request #172 from cisagov/improvement/drop-support-for-fed…

    …ora-37
    
    Remove the Fedora 37 platform
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    968cd07 View commit details
    Browse the repository at this point in the history
  24. Improve merge queue support in the CodeQL workflow

    This mirrors the changes in the build workflow inherited from
    cisagov/skeleton-generic.
    mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8849c23 View commit details
    Browse the repository at this point in the history
  25. Use cisagov/setup-env-github-action in the test job of the build

    …workflow
    
    This is necessary to populate the Python version to use.
    mcdonnnj committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ee9ef83 View commit details
    Browse the repository at this point in the history
  26. Merge pull request #182 from cisagov/bugfix/better_support_merge_queues

    Improve merge queue support in the CodeQL workflow
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    19b34da View commit details
    Browse the repository at this point in the history
  27. Merge pull request #183 from cisagov/bugfix/fix_setup-python_in_test_job

    Use `cisagov/setup-env-github-action` in the `test` job of the `build` workflow
    mcdonnnj authored Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c121f6c View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Remove duplicated instance of "ansible-galaxy"

    This is a typo.
    jsf9k committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    9471377 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #184 from cisagov/documentation/remove-duplication

    Remove duplicated instance of "ansible-galaxy"
    jsf9k authored Mar 28, 2024
    Configuration menu
    Copy the full SHA
    352e49f View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Configuration menu
    Copy the full SHA
    656ac09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    427957a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a521069 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Merge pull request #145 from cisagov/lineage/skeleton

    ⚠️ CONFLICT! Lineage pull request for: skeleton
    mcdonnnj authored Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1e346a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    060f22f View commit details
    Browse the repository at this point in the history
  3. Update repository reference in README example

    Use this repository instead of the skeleton in the `requirements.yml`
    example.
    mcdonnnj committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    96580fc View commit details
    Browse the repository at this point in the history