Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment assertion #8

Merged
merged 1 commit into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions molecule/default/tests/test_default_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,6 @@ def test_packages(host):
def test_services(host):
"""Verify that the expected services are present."""
s = host.service("systemd-resolved")
# TODO - This assertion currently fails because of
# pytest-dev/pytest-testinfra#757. Once
# pytest-dev/pytest-testinfra#754 has been merged and a new
# release is created the following line can be uncommented.
#
# See #3 for more details.
# assert s.exists, "systemd-resolved service does not exist."
assert s.exists, "systemd-resolved service does not exist."
assert s.is_enabled, "systemd-resolved service is not enabled."
assert s.is_running, "systemd-resolved service is not running."
4 changes: 3 additions & 1 deletion requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ ansible-core>=2.16.7
molecule>=5.0.1
molecule-plugins[docker]
pre-commit
pytest-testinfra
# pytest-testinfra contains a fix for SystemdService.exists that is
# required by this role's Molecule test code.
pytest-testinfra>=10.1.1
mcdonnnj marked this conversation as resolved.
Show resolved Hide resolved
Loading