Merge pull request #752 from cisagov/improvement/update_ansible_pin

Update Ansible version pin

requirements.txt

@@ -3,7 +3,25 @@
 # OS family.  This simplifies a lot of things for roles that support
 # Kali Linux, so it makes sense to force the installation of Ansible
 # 2.10 or newer.
-ansible>=2.10,<6
+#
+# We need at least version 6 to correctly identify Amazon Linux 2023
+# as using the dnf package manager, and version 8 is currently the
+# oldest supported version.
+#
+# We have tested against version 9.  We want to avoid automatically
+# jumping to another major version without testing, since there are
+# often breaking changes across major versions.  This is the reason
+# for the upper bound.
+ansible>=8,<10
+# TODO: Remove this pin when possible.  See
+# cisagov/skeleton-ansible-role#178 for more details.
+#
+# ansible-core 2.16.3 and later suffer from the bug discussed in
+# ansible/ansible#82702, which breaks any symlinked files in vars,
+# tasks, etc. for any Ansible role installed via ansible-galaxy.
+#
+# See also cisagov/skeleton-packer#312.
+ansible-core<2.16.3
 boto3
 setuptools
 wheel