Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to configure the cyhy-commander's next-scan-limit value #663

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request adds the ability to configure the next-scan-limit value in the cyhy-commander configuration file.

💭 Motivation and context

We want to update the value being deployed in production but rather than continuously modifying a hard-coded value it made sense to integrate this as a configurable value between the Ansible role and the Terraform configuration.

🧪 Testing

Automated tests pass locally. Tests on GitHub will require final resolution of #661 and integration in this branch to pass. I deployed this in my development environment with a non-default value and confirmed it deployed successfully.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 20, 2023
@mcdonnnj mcdonnnj self-assigned this Jun 20, 2023
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works for me! 🖖

I noted a nitpick, but feel free to ignore.

@mcdonnnj mcdonnnj force-pushed the improvement/configure_commander_next-scan-limit branch from 5553fed to 644a556 Compare June 21, 2023 10:53
@mcdonnnj mcdonnnj requested review from jsf9k and dav3r June 21, 2023 10:56
@mcdonnnj
Copy link
Member Author

@jsf9k @dav3r I modified this after looking at it again to change the production section instead of the DEFAULT section. I think this better aligns with what is intended and will also align with future updates to allow further customization through the Terraform configuration.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Allow configuration of the `next-scan-limit` value for the `production`
section in the configuration that is deployed for the CyHy commander.
@mcdonnnj mcdonnnj force-pushed the improvement/configure_commander_next-scan-limit branch from 644a556 to c84078b Compare August 23, 2023 16:11
@mcdonnnj mcdonnnj merged commit 41c1212 into develop Aug 24, 2023
6 checks passed
@mcdonnnj mcdonnnj deleted the improvement/configure_commander_next-scan-limit branch August 24, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants