Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show details/show less feature turned into a header for analysts #2388

Closed
abroddrick opened this issue Jun 27, 2024 · 0 comments · Fixed by #2447
Closed

Show details/show less feature turned into a header for analysts #2388

abroddrick opened this issue Jun 27, 2024 · 0 comments · Fixed by #2447
Assignees
Labels
bug Something that isn't working as intended dev

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Jun 27, 2024

Current Behavior

Currently analysts don't see the show details button as a button that shows/hides info. Instead they see the following
image
This applies to both the organization and address sections, not the status history section

Expected Behavior

The show details button should return to the old functionality, where it is a clickable button.

ETA: For both Domain and Domain Request when logged in as an Analyst

Steps to Reproduce

  1. log in as an analyst
  2. go to a domain request
  3. scroll down or search for "show details" and see it is not a button everywhere

Environment

stable and sandboxes

Additional Context

bug most likely resulted from #2337 as it was released and then this bug occurred and it changed permissions on Domain requests/ domain info.

I would suggest to stop using permission checking to hide this field and instead we cover this with the org_model feature flag.

Issue Links

No response

@abroddrick abroddrick added bug Something that isn't working as intended dev labels Jun 27, 2024
@therealslimhsiehdy therealslimhsiehdy self-assigned this Jul 3, 2024
therealslimhsiehdy added a commit that referenced this issue Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants