Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Review: View and manage organization Details #2543

Closed
4 tasks
abroddrick opened this issue Aug 6, 2024 · 8 comments · Fixed by #2734
Closed
4 tasks

Design Review: View and manage organization Details #2543

abroddrick opened this issue Aug 6, 2024 · 8 comments · Fixed by #2734

Comments

@abroddrick
Copy link
Contributor

abroddrick commented Aug 6, 2024

Issue description

In the org model, all org users should be able see information about their organization. Admins can change their organization, but no one else can. No org user can change the Senior official in these pages.

Design should review and compare the output for the organization details and compare against the most recent figma and requirements.

Acceptance criteria

  • Design reviews the organization details (mailing address and senior official)
  • Document any changes needed or new additions in a document, including with screenshots so it is easy to follow
  • Discuss changes with dev and determine which are small enough to be done as part of this ticket
  • Work with dev to create new tickets for larger changes

Additional context

Working with dev: Dev effort on this shouldn't be more than a "2" (2 full work days).

  • Dev is responsible for answering questions from design, making minor changes (such as those that we would normally make on a PR).
  • Anything that would take more than 4 hours to complete alone should be it's own ticket.
  • If the amount of changes desired would result in the dev spending more than a full day on it, make a dev ticket for items where reasonable (communicate with Alysia).

NOTE: This design review does not include testing permissions and/or sending emails. That will be tested separately once that work is implemented.

Temporary Slack channel

Discussions for this design review should take place in this Slack channel: #2543-design-review

Links to other issues

Copy link

github-actions bot commented Aug 6, 2024

cc/ @Katherine-Osos — adding you to this design-review issue!

@katypies
Copy link
Contributor

katypies commented Aug 7, 2024

@abroddrick - quick question! Will the permission levels be ready to review with this? Or should this just be scoped to the page without the permissions piece?

@abroddrick
Copy link
Contributor Author

I was not at all considering User permission management as part of this milestone, as that is a whole other can of worms. So no permissions management and viewing permissions were not be included. So basically, just details specific to the organization itself not Users in the org

@katypies
Copy link
Contributor

Re-added refinement, because we'll need to revisit the A/Cs and process once we complete the domain management review (#2544 )

@AnnaGingle
Copy link

Hey @katypies! The domain management review has been going well. We have gotten started on reviewing and Rachid has already addresses some issues.

@vickyszuchin
Copy link

Dev team effort is 2 story point, per @abroddrick

@gabydisarli
Copy link
Contributor

Design has approved PR for 2734 ✅

@abroddrick
Copy link
Contributor Author

Reopening the issue as we don't want it closed before the code is approved by dev and merged to main

rachidatecs added a commit that referenced this issue Sep 19, 2024
#2543: Org feature org pages review - [BOB] - MIGRATIONS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment