Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fixtures script to add portfolios an other missing items #2564

Closed
10 tasks done
erinysong opened this issue Aug 9, 2024 · 1 comment · Fixed by #2847
Closed
10 tasks done

Update fixtures script to add portfolios an other missing items #2564

erinysong opened this issue Aug 9, 2024 · 1 comment · Fixed by #2847

Comments

@erinysong
Copy link
Contributor

erinysong commented Aug 9, 2024

Issue description

Portfolios and organizations are currently not included in our migration seed data, which requires developers to manually make portfolios and organizations to test org model features. Adding portfolios, senior officials, organizations, suborgs to our seed script would reduce the time it takes to manually create them.

While we are changing fixtures we should go ahead and make sure all info on requests is also filled in. Right now there are some fields that don't get filled in on requests from fixtures and we should remedy that as well. Domain Requests also has new date fields and that should be included in fixtures where possible.

We are also missing domains in an expired state, as these are difficult to create manually. Thus instead of just creating one domain we should have two domains on that is in the expired state.

Likewise, we also have issues on development and staging where it would be nice to re-run the domain/domain request fixtures to create new fixtures for users. But fixtures fails usually when running again. We should make sure the fixtures won't crash/error out if you re-run it.

Acceptance criteria

  • Update fixtures script to autogenerate portfolios and any dependencies a portfolio object requires (e.g., Senior Official, Organization). This includes filling in suborg/portfolio for suborg domains
  • add "senior official" data to all portfolio domain requests and domains infos (should be covered in the AC above but here
  • add "expiration" dates to all approved domains (portfolio and non portfolio)
  • add "submission" dates to all domain requests that aren't in "started" status (portfolio and non portfolio)
  • update domain_request fixtures to match the current object (we have added fields since this was last touched)
  • add a new domain to each user that is in an expired state (aka it needs an expiration date in the past)
  • make any other fixture updates deemed beneficial that are found when going through the code, such as for other easy-to-add missing fields. (You do not need to go out of your way to look for these though, just if you see something obvious go ahead and fix that too).
  • fixtures can be re-run without crashing (logging errors though is okay)
  • on fixtures re-run more domains/domain requests should be made for the fixtures users.
  • Fixture data is only made for fixtures users, even on first runs.

Additional context

No response

Links to other issues

No response

@erinysong erinysong changed the title Add portfolio and organizations to fixtures Update fixtures script to add portfolios Aug 9, 2024
@vickyszuchin
Copy link

@abroddrick would you review and provide the story point for this ticket?

@abroddrick abroddrick changed the title Update fixtures script to add portfolios Update fixtures script to add portfolios an other missing items Aug 23, 2024
@zandercymatics zandercymatics self-assigned this Sep 11, 2024
@rachidatecs rachidatecs self-assigned this Sep 17, 2024
rachidatecs added a commit that referenced this issue Oct 1, 2024
#2564: Revise fixtures to include portfolios - [RJM]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment