Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio domain requests: Don't show delete button when the user doesn't have permissions, and fix spacing for the domain table #2754

Closed
zandercymatics opened this issue Sep 13, 2024 · 0 comments · Fixed by #2755
Assignees
Labels
bug Something that isn't working as intended dev pulled in pulled into a sprint after sprint planning

Comments

@zandercymatics
Copy link
Contributor

Current Behavior

Currently, when the user only has the view permission they can use the delete button on started domains. Additionally, the spacing is a bit wonky when the start a new domain request button appears.

Expected Behavior

The delete button is hidden and permissions block the user from accessing it when they are not permissioned to do so.
Additionally, the spacing is corrected when the button is hidden.

Steps to Reproduce

  1. With the admin role, start some new domain requests
  2. Add yourself to a portfolio as a member, but only with the view all requests permission. Note the delete button still existing

Environment

No response

Additional Context

No response

Issue Links

Introduced in this PR

@zandercymatics zandercymatics added the bug Something that isn't working as intended label Sep 13, 2024
@zandercymatics zandercymatics self-assigned this Sep 13, 2024
@vickyszuchin vickyszuchin added the pulled in pulled into a sprint after sprint planning label Sep 13, 2024
zandercymatics added a commit that referenced this issue Sep 17, 2024
Issue #2754: Don't show the delete button when the user isn't permissioned for requests - [BACKUP]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev pulled in pulled into a sprint after sprint planning
Projects
Status: ✅ Done
3 participants