Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS conflict on dt color #2841

Closed
rachidatecs opened this issue Sep 23, 2024 · 0 comments · Fixed by #2863
Closed

SCSS conflict on dt color #2841

rachidatecs opened this issue Sep 23, 2024 · 0 comments · Fixed by #2863
Assignees
Labels
bug Something that isn't working as intended dev quick fix

Comments

@rachidatecs
Copy link
Contributor

Current Behavior

In dark mode, the

element is pulling the wrong text color on the user-facing side of the app due to a conflict with some admin.scss styles

NOTE: This bug should be fixed by increasing the level of specificity on the admin scss style, not by overriding the bug with more CSS.

Expected Behavior

The color of the dt should match USWDS default or styles already defined on the user-facing scss

Steps to Reproduce

  1. Change settings to dark mode
  2. Navigate to request summary

Environment

Any

Additional Context

Screenshot 2024-09-20 at 6 48 06 PM

Issue Links

No response

@rachidatecs rachidatecs added bug Something that isn't working as intended quick fix labels Sep 23, 2024
@rachidatecs rachidatecs self-assigned this Sep 27, 2024
rachidatecs added a commit that referenced this issue Oct 1, 2024
#2841: Add specificity to the css selector for dt in dark mode - [BOB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working as intended dev quick fix
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants