-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update domain_invitation_description.html to give better direction to analysts #2344
Conversation
added more detail to give better direction to analysts
cc: @Katherine-Osos, feedback welcome. When this lands, let's update the Google Doc. |
src/registrar/templates/django/admin/includes/descriptions/domain_invitation_description.html
Outdated
Show resolved
Hide resolved
…ain_invitation_description.html Co-authored-by: zandercymatics <141044360+zandercymatics@users.noreply.github.com>
Thanks, Zander! I was definitely taking a stab in the dark and appreciate your feedback. |
@h-m-f-t Looks like it worked! There is just one more test failure on Basically the line I've outlined in the (As a side note, I think we should change that test down the line - that isn't really all that useful cc @abroddrick for thoughts) |
adding another "invited"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I had to rerun the owasp scan - its been especially flaky recently
src/registrar/templates/django/admin/includes/descriptions/domain_invitation_description.html
Outdated
Show resolved
Hide resolved
…ain_invitation_description.html Co-authored-by: Katherine-Osos <119689946+Katherine-Osos@users.noreply.github.com>
src/registrar/templates/django/admin/includes/descriptions/domain_invitation_description.html
Outdated
Show resolved
Hide resolved
…ain_invitation_description.html Co-authored-by: Katherine-Osos <119689946+Katherine-Osos@users.noreply.github.com>
The table description can be improved to give analysts better context in-platform. This change makes an attempt.