Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update domain_invitation_description.html to give better direction to analysts #2344

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

h-m-f-t
Copy link
Member

@h-m-f-t h-m-f-t commented Jun 20, 2024

The table description can be improved to give analysts better context in-platform. This change makes an attempt.

added more detail to give better direction to analysts
@h-m-f-t h-m-f-t requested a review from abroddrick as a code owner June 20, 2024 21:18
@h-m-f-t
Copy link
Member Author

h-m-f-t commented Jun 20, 2024

cc: @Katherine-Osos, feedback welcome. When this lands, let's update the Google Doc.

…ain_invitation_description.html

Co-authored-by: zandercymatics <141044360+zandercymatics@users.noreply.github.com>
@h-m-f-t
Copy link
Member Author

h-m-f-t commented Jun 22, 2024

Thanks, Zander! I was definitely taking a stab in the dark and appreciate your feedback.

@zandercymatics
Copy link
Contributor

@h-m-f-t Looks like it worked! There is just one more test failure on test_get_filters. The test is literally just counting the number of times the word "invited" appears on the page. Because your new text has the word "invited", its tripping up because now its finding 5 instances of the word rather than 4.

Basically the line I've outlined in the test_admin.py file would need to change count=4 to count=5
image

(As a side note, I think we should change that test down the line - that isn't really all that useful cc @abroddrick for thoughts)

adding another "invited"
Copy link
Contributor

@zandercymatics zandercymatics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had to rerun the owasp scan - its been especially flaky recently

…ain_invitation_description.html

Co-authored-by: Katherine-Osos <119689946+Katherine-Osos@users.noreply.github.com>
…ain_invitation_description.html

Co-authored-by: Katherine-Osos <119689946+Katherine-Osos@users.noreply.github.com>
@h-m-f-t h-m-f-t merged commit e5ddcfe into main Aug 1, 2024
10 checks passed
@h-m-f-t h-m-f-t deleted the h-m-f-t-patch-1 branch August 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants