-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2398: Workflow - Manual deploy branch to environment part 1/2 #2458
Conversation
…-sandbox-deploy-workflow
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
🥳 Successfully deployed to developer sandbox es. |
1 similar comment
🥳 Successfully deployed to developer sandbox es. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and tested this for you:
https://github.com/CocoByte/manage.get.gov.nl.fork/actions/runs/9964830281/job/27533950015
Looks like there was an issue with comments (could be a config issue in my branch though so I'm going to double-check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think the reason the comment didn't work has to do with another secret I am missing in my forked branch. I checked out the deploy action itself and it appears to work great!
Approved -- just double-check the comment portion
Thank you for testing it locally @CocoByte! Will merge and keep an eye for the workflow you mentioned when testing 🎉 |
Ticket
Resolves #2398 - Part 1/2.
Changes
Context for reviewers
This workflow is meant to merge to main so that the workflow is available to test. Once workflow is verified to work, I will post another PR so that newly created sandboxes are also added to this workflow's environment choices and update docs to add this workflow as a deploy option.
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots