-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE #1261: Hide urbanization field if non-PR #2477
Conversation
🥳 Successfully deployed to developer sandbox rh. |
🥳 Successfully deployed to developer sandbox rh. |
🥳 Successfully deployed to developer sandbox rh. |
🥳 Successfully deployed to developer sandbox rh. |
@therealslimhsiehdy is this currently staged on rh sandbox? I am not seeing the behavior I expect |
@dave-kennedy-ecs Just re-deployed and the change should now be back on the rh sandbox! Let me know if it still doesn't look right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on RH sandbox. Reviewed code. LGTM
Ticket
Resolves #1261
Changes
Organization name and mailing address
tab, when you choose any other state other than Puerto Rico, the Urbanization field should NOT show up. If Puerto Rico is selected, the Urbanization field should show up (see screenshot for referenceContext for reviewers
Setup
Organization name and mailing address
sectionState, territory, or military post *
as anything other than Puerto Rico and vice versa to Puerto Rico so you can see Urbanization displayed versus notCode Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots