-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove versioning in docker-compose.yml #2478
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works for me
Looks like we're getting a failure on our other jobs, too! |
we're getting a exit handler bug on npm itself. It looks like we may (potentially) need to revert the version on node, again: |
@@ -53,6 +53,7 @@ jobs: | |||
- name: Compile USWDS assets | |||
working-directory: ./src | |||
run: | | |||
docker compose run node npm install npm@latest && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@therealslimhsiehdy add this to deploy-sandbox.yaml and deploy-development.yaml. If after merging we have no issues then we can add to the staging and stable deploys too
Zander, the build pulls off of main. It is not utilizing her changes at all. Yaml changes need to merge to main to take effect unless you have a workflow (like the manual deploy workflow) that can deploy based on a particular branch of code. The deploy failing here is irrelevant |
🥳 Successfully deployed to developer sandbox rh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, let's try it! If it goes to development fine and we can re-deploy the failing PRs successfully we can add the same line to stable/staging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
Resolves #00
See slack thread for the versioning and NPM issues we were running into here and the errors
Changes
Context for reviewers
Setup
Code Review Verification Steps
As the original developer, I have
Satisfied acceptance criteria and met development standards
Ensured code standards are met (Original Developer)
Validated user-facing changes (if applicable)
As a code reviewer, I have
Reviewed, tested, and left feedback about the changes
Ensured code standards are met (Code reviewer)
Validated user-facing changes as a developer
New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Meets all designs and user flows provided by design/product
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers, the suggestion is to use ones that the developer didn't (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist
As a designer reviewer, I have
Verified that the changes match the design intention
Validated user-facing changes as a designer
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
(Rarely needed) Tested as both an analyst and applicant user
Screenshots