Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2016: Text wrapping to next line for an overflow in domain name - [RH] #2825

Merged
merged 3 commits into from
Sep 23, 2024
Merged

#2016: Text wrapping to next line for an overflow in domain name - [RH] #2825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
719ce00
Add SCSS for lengthy domain names
therealslimhsiehdy Sep 19, 2024
b36bd28
Update SCSS to allow wrapping instead of truncating
therealslimhsiehdy Sep 20, 2024
56a7cf6
Remove extra comments
therealslimhsiehdy Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/registrar/assets/sass/_theme/_admin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,3 +930,10 @@ ul.add-list-reset {
.dl-dja dt {
font-size: 14px;
}

.domain-name-truncate {
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
max-width: 100%;
}
2 changes: 1 addition & 1 deletion src/registrar/templates/domain_base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<div class="grid-row grid-gap">
<div class="tablet:grid-col-3">
<p class="font-body-md margin-top-0 margin-bottom-2
Copy link
Contributor

@erinysong erinysong Sep 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @AnnaGingle @kristinacyin since you're both knowledgeable in current practices!

Will defer to designers since I'm not as up to date on how to handle overflow text accessibly, but do we want to add aria text here given that you can't see the rest of the domain? I know there's differing opinions on if aria text is helpful or not
image

text-primary-darker text-semibold"
text-primary-darker text-semibold domain-name-truncate"
>
<span class="usa-sr-only"> Domain name:</span> {{ domain.name }}
</p>
Expand Down
Loading