#2725: member management page - [NL] #2837

CocoByte · 2024-09-21T21:58:24Z

Ticket 2725

Resolves #2725

Change

Created the initial members management page features according to the ACs in the ticket
Added unit tests

Context for reviewers

Setup

Code is deployed on sandbox-nl

Since we don't have fixtures for this yet, you will need to setup a portfolio, assign a few domains to it, and give users portfolio permissions.

To do this, navigate to /admin and do the following (NOTE: if the database has not been reset, these are likely already done.);

Enable the org model waffle flags.
Create a portfolio
Create a suborg
Open a few domains and assign them to the portfolio & suborg
Go to /admin and Create a couple portfolio permissions (one with admin, and one without), assigning these permissions to the portfolio you made earlier. Also invite a user to the portfolio.

Code Review Verification Steps

---- BEGIN ----

After completing setup, navigate to /domains and verify...

That /domains loads fine (indicating you completed setup correctly)

Navigate to /members (in the url) and verify the following (NOTE: you might wish to open a separate tab to change permissions in order to test these scenarios)...

You can only view the members page (and members link in the top nav) if you have the "View Members" permission explicitly assigned in members portfolio (being admin is not enough to see this page). (See Ticket AC: "admin roles do not naturally have the ability to see all users and/or manage them. This has to be layered on")
The members table has manage (gear) icons that appear if the you have permissions to edit/manage members (Portfolio Permissions) AND permissions to change users (permissions in your User model -- NOTE: full access groups AND analysts can change users. If you remove both of these groups, the only way to enable the "Manage" setting on the members page is to add "Registrar | Users| Change users" as a custom permission). A view icon appears if you do not have these permissions (view members / view users only)
The members table shows member email, last active date or that the user is just in the invited state
search bar, sort, pagination and overall formatting such as title is included
the add a new member button is shown but does nothing
"admin" tags are displayed for anyone with the role "admin"
the users that show on this table are both those who have UserPortfolioPermissions and those who have just been invited to the portfolio

One final AC to check:
In /admin, verify that...

Portfolio Permissions no longer has "Read Only Admin" in the list of available roles

---- DONE ----

As the original developer, I have

Satisfied acceptance criteria and met development standards

Met the acceptance criteria, or will meet them in a subsequent PR
Created/modified automated tests
Added at least 2 developers as PR reviewers (only 1 will need to approve)
Messaged on Slack or in standup to notify the team that a PR is ready for review
Changes to “how we do things” are documented in READMEs and or onboarding guide
If any model was updated to modify/add/delete columns, makemigrations was ran and the associated migrations file has been commited.

Ensured code standards are met (Original Developer)

All new functions and methods are commented using plain language
Did dependency updates in Pipfile also get changed in requirements.txt?
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values

Validated user-facing changes (if applicable)

New pages have been added to .pa11yci file so that they will be tested with our automated accessibility testing
Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Add at least 1 designer as PR reviewer

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Pulled this branch locally and tested it
Reviewed this code and left comments
Checked that all code is adequately covered by tests
Made it clear which comments need to be addressed before this work is merged
If any model was updated to modify/add/delete columns, makemigrations was ran and the associated migrations file has been commited.

Ensured code standards are met (Code reviewer)

All new functions and methods are commented using plain language
Interactions with external systems are wrapped in try/except
Error handling exists for unusual or missing values
(Rarely needed) Did dependency updates in Pipfile also get changed in requirements.txt?

Validated user-facing changes as a developer

Note: Multiple code reviewers can share the checklists above, a second reviewers should not make a duplicate checklist

As a designer reviewer, I have

Verified that the changes match the design intention

Checked that the design translated visually
Checked behavior
Checked different states (empty, one, some, error)
Checked for landmarks, page heading structure, and links
Tried to break the intended flow

Validated user-facing changes as a designer

Checked keyboard navigability
Tested general usability, landmarks, page header structure, and links with a screen reader (such as Voiceover or ANDI)
Tested with multiple browsers (check off which ones were used)
- Chrome
- Microsoft Edge
- FireFox
- Safari
(Rarely needed) Tested as both an analyst and applicant user

Screenshots

…ment-page

github-actions · 2024-09-21T22:02:36Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2024-09-23T22:10:02Z

🥳 Successfully deployed to developer sandbox nl.

…ment-page

github-actions · 2024-09-24T04:22:28Z

🥳 Successfully deployed to developer sandbox nl.

…w/edit members

github-actions · 2024-09-25T01:26:38Z

🥳 Successfully deployed to developer sandbox nl.

…t User objects in the DB

github-actions · 2024-09-30T15:46:47Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2024-09-30T15:48:47Z

🥳 Successfully deployed to developer sandbox nl.

src/registrar/views/portfolio_members_json.py

src/registrar/views/portfolios.py

src/registrar/assets/js/get-gov.js

src/registrar/tests/test_views_portfolio.py

rachidatecs · 2024-09-30T19:31:01Z

src/registrar/tests/test_views_portfolio.py

@@ -666,6 +667,194 @@ def test_organization_members_waffle_flag_on_shows_nav_link(self):
        self.assertContains(home, "Hotel California")
        self.assertContains(home, "Members")

+    @less_console_noise_decorator


We are missing test_views_members_json (see similar test files)

rachidatecs · 2024-09-30T19:32:30Z

Mostly nitpicks but overall great work @CocoByte!

Co-authored-by: Rachid Mrad <107004823+rachidatecs@users.noreply.github.com>

github-actions · 2024-10-01T20:55:23Z

🥳 Successfully deployed to developer sandbox nl.

CocoByte · 2024-10-01T21:13:57Z

Thank you @zandercymatics and @rachidatecs for the thorough review and polishing :)

…anage.get.gov into nl/2725-member-management-page

github-actions · 2024-10-01T21:32:02Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2024-10-01T21:37:55Z

🥳 Successfully deployed to developer sandbox nl.

src/registrar/templatetags/custom_filters.py

zandercymatics · 2024-10-02T15:15:17Z

@rachidatecs / @CocoByte Adding those missing unit tests. Kept it simple for now. I also fixed a few bugs with the search, sort, etc

github-actions · 2024-10-02T16:17:35Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2024-10-02T16:27:44Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2024-10-02T17:40:31Z

🥳 Successfully deployed to developer sandbox nl.

github-actions · 2024-10-02T20:26:37Z

🥳 Successfully deployed to developer sandbox nl.

rachidatecs · 2024-10-03T16:10:54Z

src/registrar/tests/test_views_members_json.py

+from django_webtest import WebTest  # type: ignore
+
+
+class GetPortfolioMembersJsonTest(TestWithUser, WebTest):


Add a teardown class and cleanup the data

rachidatecs

Add a teardown class for the new test class

CocoByte added 3 commits September 20, 2024 12:28

Initial Scaffolding (in progress)

6954c1c

Initial scaffold for members page completed

64b62f1

Merge remote-tracking branch 'origin/main' into nl/2725-member-manage…

7bd0b06

…ment-page

CocoByte requested a review from abroddrick as a code owner September 21, 2024 21:58

CocoByte added 4 commits September 22, 2024 22:07

data loads now

d7fa9e8

Updated data, added manage/view icon, search & sort functionality

ecf2e4d

Add member button (scaffold)

2122745

Delete permission settings around "add member" button

64e623e

CocoByte added 2 commits September 23, 2024 22:18

Added admin tag, added user invites logic

5e2a1ce

Merge remote-tracking branch 'origin/main' into nl/2725-member-manage…

21b7cba

…ment-page

CocoByte added 6 commits September 24, 2024 18:27

Delete Admin read-only (comment out, just in case)

a8b26e3

Update comments

b85c031

Adjust permissions so admins do not automatically have ability to vie…

8937892

…w/edit members

Cleanup

8673bc8

linted

1ad805b

Removed unnecessary SCSS color override for tags

91553ab

CocoByte changed the title ~~[IGNORE] Issue #2725: member management page - [NL]~~ Issue #2725: member management page - [NL] Sep 25, 2024

CocoByte requested review from rachidatecs, zandercymatics, therealslimhsiehdy, dave-kennedy-ecs, a team, erinysong and asaki222 September 25, 2024 17:29

CocoByte added 2 commits September 25, 2024 11:43

Added logic for restricting editing members to only those who can edi…

140d342

…t User objects in the DB

Added some unit tests (need to fix failures still)

6ca8f69

Update members_table.html

fe31dbd

rachidatecs reviewed Sep 30, 2024

View reviewed changes

src/registrar/views/portfolio_members_json.py Outdated Show resolved Hide resolved

rachidatecs reviewed Sep 30, 2024

View reviewed changes

Update src/registrar/tests/test_views_portfolio.py

95cf224

Co-authored-by: Rachid Mrad <107004823+rachidatecs@users.noreply.github.com>

Pr suggestions ( minus tests )

c85ef25

zandercymatics added 2 commits October 1, 2024 15:27

Merge branch 'nl/2725-member-management-page' of github.com:cisagov/m…

18e4647

…anage.get.gov into nl/2725-member-management-page

fix bug

7b09b35

pass in portfolio

72afa03

rachidatecs reviewed Oct 1, 2024

View reviewed changes

src/registrar/templatetags/custom_filters.py Outdated Show resolved Hide resolved

src/registrar/templatetags/custom_filters.py Outdated Show resolved Hide resolved

zandercymatics added 2 commits October 2, 2024 08:46

fix tests

4e9a58b

fix sorting + unit tests

b497931

lint

d451297

fix test

76473e2

rachidatecs changed the title ~~Issue #2725: member management page - [NL]~~ #2725: member management page - [NL] Oct 2, 2024

rachidatecs reviewed Oct 3, 2024

View reviewed changes

rachidatecs approved these changes Oct 3, 2024

View reviewed changes

CocoByte merged commit 9aa3504 into main Oct 3, 2024
9 of 10 checks passed

CocoByte deleted the nl/2725-member-management-page branch October 3, 2024 16:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2725: member management page - [NL] #2837

#2725: member management page - [NL] #2837

CocoByte commented Sep 21, 2024 •

edited

Loading

github-actions bot commented Sep 21, 2024

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

rachidatecs Sep 30, 2024

rachidatecs commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

CocoByte commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

zandercymatics commented Oct 2, 2024 •

edited

Loading

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

rachidatecs Oct 3, 2024

rachidatecs left a comment

		from django_webtest import WebTest # type: ignore


		class GetPortfolioMembersJsonTest(TestWithUser, WebTest):

#2725: member management page - [NL] #2837

#2725: member management page - [NL] #2837

Conversation

CocoByte commented Sep 21, 2024 • edited Loading

Ticket 2725

Change

Context for reviewers

Setup

Code Review Verification Steps

---- BEGIN ----

---- DONE ----

As the original developer, I have

Satisfied acceptance criteria and met development standards

Ensured code standards are met (Original Developer)

Validated user-facing changes (if applicable)

As a code reviewer, I have

Reviewed, tested, and left feedback about the changes

Ensured code standards are met (Code reviewer)

Validated user-facing changes as a developer

As a designer reviewer, I have

Verified that the changes match the design intention

Validated user-facing changes as a designer

Screenshots

github-actions bot commented Sep 21, 2024

github-actions bot commented Sep 23, 2024

github-actions bot commented Sep 24, 2024

github-actions bot commented Sep 25, 2024

github-actions bot commented Sep 30, 2024

github-actions bot commented Sep 30, 2024

rachidatecs Sep 30, 2024

Choose a reason for hiding this comment

rachidatecs commented Sep 30, 2024

github-actions bot commented Oct 1, 2024

CocoByte commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

github-actions bot commented Oct 1, 2024

zandercymatics commented Oct 2, 2024 • edited Loading

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

rachidatecs Oct 3, 2024

Choose a reason for hiding this comment

rachidatecs left a comment

Choose a reason for hiding this comment

CocoByte commented Sep 21, 2024 •

edited

Loading

zandercymatics commented Oct 2, 2024 •

edited

Loading