-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ CONFLICT! Lineage pull request for: skeleton #80
Commits on May 21, 2024
-
Modify the ansible-core pin to ensure a good version is used
We can do this because new versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected.
Configuration menu - View commit details
-
Copy full SHA for 297ce13 - Browse repository at this point
Copy the full SHA 297ce13View commit details -
Pin ansible-core when running the ansible-lint linter
New versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 07e2b60 - Browse repository at this point
Copy the full SHA 07e2b60View commit details -
The line is not only unnecessary, it was commented out to boot!
Configuration menu - View commit details
-
Copy full SHA for c74e5db - Browse repository at this point
Copy the full SHA c74e5dbView commit details -
Explain why ansible may need to be added as a dependency for ansible-…
…lint On its own ansible-lint does not pull in ansible, only ansible-core. Therefore, if an Ansible module lives in ansible instead of ansible-core, the linter will complain that the module is unknown. In these cases it is necessary to add the ansible package itself as an additional dependency, with the same pinning as is done in requirements-test.txt of cisagov/skeleton-ansible-role.
Configuration menu - View commit details
-
Copy full SHA for 2e53e0d - Browse repository at this point
Copy the full SHA 2e53e0dView commit details
Commits on Jun 6, 2024
-
Update pre-commit hook versions
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier was manually held back because the latest tags are for alpha releases of the next major version.
Configuration menu - View commit details
-
Copy full SHA for f51fe62 - Browse repository at this point
Copy the full SHA f51fe62View commit details -
Manually update the prettier hook
Use the latest v3 release available from NPM.
Configuration menu - View commit details
-
Copy full SHA for 8e55b8e - Browse repository at this point
Copy the full SHA 8e55b8eView commit details -
Correct commented-out ansible pin
The pin now agrees with what is in cisagov/skeleton-ansible-role. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c617bb9 - Browse repository at this point
Copy the full SHA c617bb9View commit details -
Merge pull request #183 from cisagov/maintenance/update_pre-commit_hooks
Update `pre-commit` hooks
Configuration menu - View commit details
-
Copy full SHA for de92c3c - Browse repository at this point
Copy the full SHA de92c3cView commit details -
Merge pull request #182 from cisagov/improvement/pin-packages-for-ans…
…ible-lint Pin packages for `ansible-lint`
Configuration menu - View commit details
-
Copy full SHA for 7ddea47 - Browse repository at this point
Copy the full SHA 7ddea47View commit details -
Merge https://github.com/cisagov/skeleton-generic into lineage/skeleton
mcdonnnj committedJun 6, 2024 Configuration menu - View commit details
-
Copy full SHA for bc369af - Browse repository at this point
Copy the full SHA bc369afView commit details
Commits on Aug 12, 2024
-
Merge pull request #338 from cisagov/improvement/remove-ansible-core-pin
Update version pin on `ansible-core` Python package
Configuration menu - View commit details
-
Copy full SHA for b66d137 - Browse repository at this point
Copy the full SHA b66d137View commit details -
Merge pull request #343 from cisagov/lineage/skeleton
Lineage pull request for: skeleton
Configuration menu - View commit details
-
Copy full SHA for 6334bf2 - Browse repository at this point
Copy the full SHA 6334bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6041172 - Browse repository at this point
Copy the full SHA 6041172View commit details -
Add a filter for the AMI's architecture
This is more flexible than filtering the architecture just based on the name, particularly since the name filter does not support full-fledged regexes.
Configuration menu - View commit details
-
Copy full SHA for 89c7e1e - Browse repository at this point
Copy the full SHA 89c7e1eView commit details -
Add an architecture filter in the Packer config
This should make the search more efficient.
Configuration menu - View commit details
-
Copy full SHA for d58b660 - Browse repository at this point
Copy the full SHA d58b660View commit details -
Add an ARM64 source to the Packer configuration
This will allow us to build both x86-64 and ARM64 versions of our AMI.
Configuration menu - View commit details
-
Copy full SHA for aaeb8bd - Browse repository at this point
Copy the full SHA aaeb8bdView commit details -
Build both the x86-64 and ARM64 versions of the AMI
In order that the builds should complete as soon as possible, the different architectures are built in parallel.
Configuration menu - View commit details
-
Copy full SHA for 2452ca5 - Browse repository at this point
Copy the full SHA 2452ca5View commit details -
Update the AMI filter to include both the x86-64 and ARM64 AMIs
We want to be able to offer both wherever possible.
Configuration menu - View commit details
-
Copy full SHA for 8dec775 - Browse repository at this point
Copy the full SHA 8dec775View commit details -
Configuration menu - View commit details
-
Copy full SHA for 793b46d - Browse repository at this point
Copy the full SHA 793b46dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95dc9a3 - Browse repository at this point
Copy the full SHA 95dc9a3View commit details -
Reorder data blocks to match order of source blocks
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for f6dbbb8 - Browse repository at this point
Copy the full SHA f6dbbb8View commit details -
Create separate resources for ARM64 and x86-64 AMIs and launch permis…
…sions Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9332c38 - Browse repository at this point
Copy the full SHA 9332c38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18765c6 - Browse repository at this point
Copy the full SHA 18765c6View commit details -
Add comments to moved blocks to explain the intent
Also reference issue cisagov/skeleton-packer#369 to consider removing the moved blocks when they are no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for 51944d0 - Browse repository at this point
Copy the full SHA 51944d0View commit details -
Co-authored-by: David Redmin <david.redmin@gwe.cisa.dhs.gov>
Configuration menu - View commit details
-
Copy full SHA for 88528fe - Browse repository at this point
Copy the full SHA 88528feView commit details -
Configuration menu - View commit details
-
Copy full SHA for f161416 - Browse repository at this point
Copy the full SHA f161416View commit details -
Merge pull request #355 from cisagov/improvement/specify-architecture…
…s-as-separate-filter Build both ARM64 and x86-64 AMIs
Configuration menu - View commit details
-
Copy full SHA for d44181d - Browse repository at this point
Copy the full SHA d44181dView commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cc75030 - Browse repository at this point
Copy the full SHA cc75030View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cb7c40 - Browse repository at this point
Copy the full SHA 3cb7c40View commit details -
Configuration menu - View commit details
-
Copy full SHA for 31a3571 - Browse repository at this point
Copy the full SHA 31a3571View commit details -
Configuration menu - View commit details
-
Copy full SHA for d677433 - Browse repository at this point
Copy the full SHA d677433View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bd9cfc - Browse repository at this point
Copy the full SHA 0bd9cfcView commit details