Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of collections from comment #165

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 1, 2023

🗣 Description

This pull request removes the mention of adding collection dependencies to meta/requirements.yml.

💭 Motivation and context

ansible-galaxy does not appear to allow roles to depend on collections. See here for more details.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

ansible-galaxy does not appear to allow roles to depend on
collections.  See here for more details:
#153 (comment)
@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Nov 1, 2023
@jsf9k jsf9k marked this pull request as ready for review November 1, 2023 17:57
@jsf9k jsf9k requested a review from a team November 1, 2023 17:57
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 27, 2024
@mcdonnnj mcdonnnj removed this pull request from the merge queue due to the queue being cleared Mar 27, 2024
@mcdonnnj mcdonnnj added this pull request to the merge queue Mar 27, 2024
Merged via the queue into develop with commit 13a4fb2 Mar 27, 2024
12 checks passed
@mcdonnnj mcdonnnj deleted the documentation/no-collections-in-meta branch March 27, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants