Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder that pin must be in sync with two other places #191

Closed
wants to merge 1 commit into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented May 5, 2024

🗣 Description

This pull request modifies a comment to remind us that the ansible-core pin must stay in sync across this repo as well as:

💭 Motivation and context

If we update the pin in one place we must remember to update it in the two other places.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

cisagov/skeleton-generic, cisagov/skeleton-ansible-role, and
cisagov/skeleton-packer all must pin ansible-core and stay in sync.
@jsf9k jsf9k added the documentation This issue or pull request improves or adds to documentation label May 5, 2024
@jsf9k jsf9k self-assigned this May 5, 2024
@jsf9k jsf9k marked this pull request as ready for review May 5, 2024 02:55
@jsf9k jsf9k requested a review from a team May 5, 2024 02:55
@jsf9k jsf9k added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label May 7, 2024
@jsf9k
Copy link
Member Author

jsf9k commented May 21, 2024

We can close this pull request because a new version of the ansible-core Python package has been released that does not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy.

See also #193.

@jsf9k jsf9k closed this May 21, 2024
@jsf9k jsf9k deleted the improvement/improve-comment branch May 21, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants