Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite modexp with numext #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Rewrite modexp with numext #39

wants to merge 3 commits into from

Conversation

mohanson
Copy link
Collaborator

Note: Currently I use

numext-fixed-uint = { git = "https://github.com/yangby-cryptape/rust-numext", branch = "fix-div-slow-bug" }

in dependencies because @yangby-cryptape tell me It may take some times to waiting for the fix to merge to the master.

@mohanson mohanson requested a review from yejiayu March 27, 2019 05:00
@keroro520
Copy link
Contributor

muta is using numext-fixed-uint = "0.1.2" but here is "0.1.3"

Maybe it is better that cita-vm and muta use the same version of numext-fixed-* ?

@mohanson
Copy link
Collaborator Author

mohanson commented Apr 3, 2019

There are some bugs in numext-fixed-uint = 0.1.2, I will update it on muta.

ref: cryptape/rust-numext#36
ref: cryptape/rust-numext#34

@keroro520
Copy link
Contributor

There are some bugs in numext-fixed-uint = 0.1.2, I will update it on muta.

ref: cryptape/rust-numext#36
ref: cryptape/rust-numext#34

Excellent !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants