Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename hochschule-bonn-rhein-sieg.csl to hochschule-bonn-r… #7242

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented Oct 7, 2024

…hein-sieg-harvard.csl

  1. I had a look at the old guidelines via archive.org and they were actually for the economics faculty. Hence I added that to the style name.
  2. As the style also describes a footnote variant I have also added "harvard" to the file name, so we don't need to change that in the future.

Guidelines (sent to me via email):
Leitfaden fuer die Gestaltung schriftlicher Arbeiten .pdf

Copy link

github-actions bot commented Oct 7, 2024

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

4 tests failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

hochschule-bonn-rhein-sieg-harvard: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [22, "22:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

hochschule-bonn-rhein-sieg-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

hochschule-bonn-rhein-sieg-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

3 tests failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

hochschule-bonn-rhein-sieg-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

hochschule-bonn-rhein-sieg-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

Please check the test report for details.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

3 tests failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard: "self" link must match the style ID

expected: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-wirtschaftswissenschaften-harvard"
     got: "http://www.zotero.org/styles/hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard"

(compared using ==)

Please check the test report for details.

…n-harvard.csl to hochschule-bonn-rhein-sieg-fachbereich-wirtschaftswissenschaften-harvard.csl
Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

@POBrien333
Copy link
Contributor Author

Not sure where it's getting the "freie-hochschule-stuttgart" from?!

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

Copy link

github-actions bot commented Oct 7, 2024

😟 There are some issues with your submission.

1 test failed

freie-hochschule-stuttgart: "template" link must point to an existing independent style

expected ["academy-of-management-review", "accident-analysis-and-prevention", "aci-materials-journal", "acm-si...chaftlichen-arbeiten", "zoological-journal-of-the-linnean-society", "zootaxa", "zwitscher-maschine"] to include "hochschule-bonn-rhein-sieg"

Please check the test report for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant