Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nintendo 64 widescreen launcher #49

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Add Nintendo 64 widescreen launcher #49

merged 6 commits into from
Jun 26, 2024

Conversation

cobaltgit
Copy link
Contributor

@cobaltgit cobaltgit commented Jun 25, 2024 •
edited
Loading

May need testing, the overlay might still be displaying when it shouldn't be??
Also update mupen64plus to use dynamic recompiler

@cizia64
Copy link
Owner

cizia64 commented Jun 26, 2024

Review:
Duplicated lines: https://github.com/cizia64/CrossMix-OS/pull/49/files#diff-108a4ad1b99f02add643ee6da34727f7f271ce4612951b0ec287a1640bb5ded6R3
Copy error here: https://github.com/cizia64/CrossMix-OS/pull/49/files#diff-108a4ad1b99f02add643ee6da34727f7f271ce4612951b0ec287a1640bb5ded6R38
May be only keep mupen64plus-aspect = "16:9 adjusted" to avoid to override other settings from the user here.

@cizia64 cizia64 merged commit c39747e into cizia64:main Jun 26, 2024
@cobaltgit cobaltgit deleted the feature/n64-widescreen branch June 26, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cobaltgit cobaltgit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cobaltgit @cizia64