Feature/add creator support #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 9, 2024 15:38
- Introduced creator fields (URI, name, email, URL, type, identifier) alongside publisher fields. - Updated the RDF graph serialization to include creator details. - Extended existing tests to validate the creator functionality. - Applied similar fallback logic for creator as used for publisher.
…add-creator-support
…add-creator-support
hcvdwerf
force-pushed
the
feature/add-creator-support
branch
from
40a9ba3
to
253b552
Compare
hcvdwerf
force-pushed
the
feature/add-creator-support
branch
from
387d0d3
to
f7da907
Compare
|
@amercader Do you have time to review this one? Thanks in advance! |
|
Thanks for this @hcvdwerf , I have many open fronts but will get to this eventually! |
amercader
reviewed
Oct 1, 2024
| ("notes", DCT.description), | ||
| ("url", DCAT.landingPage), | ||
| ("version", OWL.versionInfo), | ||
| ("title", DCT.title), |
There was a problem hiding this comment.
Please don't include formatting changes like these ones
| help_text: Entity responsible for making the dataset available. | ||
|
|
||
| - field_name: creator |
There was a problem hiding this comment.
creator was not part of the recommended properties in DCAT AP 2 so let's keep it just in the full schema.
examples/ckan/dataset.json
Outdated
| "title": ""}] | ||
| "creator": { | ||
| "name": "John Doe", | ||
| "mbox": "johndoe@example.com" |
There was a problem hiding this comment.
This should be "email" as per the definition in the schema files, and the publisher above is wrong too. mbox was used in a really ancient parser no longer supported
Suggested change
| "mbox": "johndoe@example.com" | |
| "email": "johndoe@example.com" |
examples/ckan/temp
Outdated
- Added fields to store creator details (name, email, URL, and identifier) in the DCAT profile. - Implemented functionality to serialize and deserialize creator information similar to the publisher. - Updated RDF generation logic to include creator fields in the output graph. - Enhanced unit tests to verify proper handling and serialization of creator metadata.
hcvdwerf
force-pushed
the
feature/add-creator-support
branch
from
d045430
to
d8461e2
Compare
hcvdwerf
commented
Oct 3, 2024
There was a problem hiding this comment.
@amercader Thank you for your comments, @amercader! I’ve made adjustments to the code based on your feedback.
| help_text: Entity responsible for making the dataset available. | ||
|
|
||
| - field_name: creator |
| ("notes", DCT.description), | ||
| ("url", DCAT.landingPage), | ||
| ("version", OWL.versionInfo), | ||
| ("title", DCT.title), |
examples/ckan/dataset.json
Outdated
| "title": ""}] | ||
| "creator": { | ||
| "name": "John Doe", | ||
| "mbox": "johndoe@example.com" |
examples/ckan/temp
Outdated
|
Thanks @hcvdwerf , nice one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Creator Support to DCAT Extension
This PR introduces functionality for managing and displaying creator information in datasets, aligning with the DCAT vocabulary. Key additions include:
Creator Fields: Similar to the publisher, we now support creator metadata fields:
creator_name: The name of the dataset creator.creator_email: The creator's email address.creator_url: The homepage or URL related to the creator.creator_identifier: A unique identifier for the creator, such as an ORCID or other URI.RDF Serialization/Deserialization:
Unit Tests:
This enhancement aligns with the ongoing efforts to ensure full support for the DCAT-AP 2/3 profiles in CKAN's DCAT extension and improves metadata expressiveness by adding proper attribution for dataset creators.