Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves URI from contact point #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hcvdwerf
Copy link
Contributor

@hcvdwerf hcvdwerf commented Oct 3, 2024

Description:

This pull request introduces functionality to resolve URIs for contact details, specifically targeting the retrieval of more detailed information (e.g., ORCID). Previously, the contact["uri"] field defaulted to either a string or an empty value. With this update, we attempt to resolve the URI and retrieve associated metadata (e.g., VCARD.hasUID) when available.

Changes:

  • Updated the _contact_details method to resolve URIs where applicable.
  • For agents that are not URIRef, the system now attempts to fetch the VCARD.hasUID property to enrich the URI field.

Benefits:

  • Improved Metadata Access: Resolving URIs, such as ORCIDs, allows us to retrieve richer and more accurate contact data (e.g., full names, affiliations, email addresses).

@amercader
Copy link
Member

Wouldn't it make more sense to store VCARD.hasUID in a dedicated key like contact["identifier"]. I get that in the case of ORCID those happen to be URIs as well but that might not be always be the case right? e.g. if using a UUID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants