Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Rename ArgValue to PossibleValue #2908

Merged
merged 1 commit into from
Oct 19, 2021
Merged

fix!: Rename ArgValue to PossibleValue #2908

merged 1 commit into from
Oct 19, 2021

Conversation

epage
Copy link
Member

@epage epage commented Oct 18, 2021

In considering potential work for #2683, I realized we might need a type to carry data for
each of the multiple_values. ArgValue works both for that and for
possible values, so we need to come up with a better name for one or
both. Changing ArgValues name now would be ideal since its new in
clap3 and by renaming it, we can reduce churn for users.

While thinking about this, I realized I regularly get these mixed
up, so renaming ArgValue to PossibleValue I think will help clear
things up, regardless of #2683.

Copy link
Member

@pksunkara pksunkara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge after fixing tests.

In considering potential work for clap-rs#2683, I realized we might need a type to carry data for
each of the `multiple_values`.  `ArgValue` works both for that and for
possible values, so we need to come up with a better name for one or
both.  Changing `ArgValue`s name now would be ideal since its new in
clap3 and by renaming it, we can reduce churn for users.

While thinking about this, I realized I regularly get these mixed
up, so renaming `ArgValue` to `PossibleValue` I think will help clear
things up, regardless of clap-rs#2683.
@epage
Copy link
Member Author

epage commented Oct 19, 2021

bors r=pksunkara

@bors
Copy link
Contributor

bors bot commented Oct 19, 2021

Build succeeded:

@bors bors bot merged commit 07ec044 into clap-rs:master Oct 19, 2021
@epage epage deleted the possible branch October 19, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants