Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(complete): Unblock E2E dynamic completion tests #5049

Merged
merged 9 commits into from
Jul 28, 2023
Merged

Conversation

epage
Copy link
Member

@epage epage commented Jul 28, 2023

This was split out of #5048 to iterate on some ideas to deal with the challenges involved

  • I ran into issues with the test command (I assume that is why feat(completions): Dynamic fish completions #5048 had testcomp). I chose exhaustive to describe what it does.
  • Don't use separate target directories but have the binaries work as one
    • This meant dealing with the static tests needing to generate the same result, independent of unstable-dynamic, so I made the tests always enable it

I held off on adding the bash completion test because the order varies between my machine and CI.

@epage epage changed the title test(complete): Do E2E dynamic completion tests test(complete): Unblock E2E dynamic completion tests Jul 28, 2023
@ModProg
Copy link
Contributor

ModProg commented Jul 28, 2023

This looks definitely better.

@epage epage merged commit a3d93f4 into clap-rs:master Jul 28, 2023
21 checks passed
@epage epage deleted the dyn branch July 28, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants