Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(complete): Make Shells more flexible #5679

Merged
merged 2 commits into from
Aug 16, 2024
Merged

feat(complete): Make Shells more flexible #5679

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
661ccc2
feat(complete): Make Shells::builtins const
epage Aug 16, 2024
f969bec
feat(complete): Add Shells::iter
epage Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clap_complete/src/dynamic/env/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ pub struct Shells<'s>(pub &'s [&'s dyn EnvCompleter]);

impl<'s> Shells<'s> {
/// Select all of the built-in shells
pub fn builtins() -> Self {
pub const fn builtins() -> Self {
Self(&[&Bash, &Elvish, &Fish, &Powershell, &Zsh])
}

Expand All @@ -245,6 +245,11 @@ impl<'s> Shells<'s> {
pub fn names(&self) -> impl Iterator<Item = &'static str> + 's {
self.0.iter().map(|c| c.name())
}

/// Iterate over [`EnvCompleter`]s
pub fn iter(&self) -> impl Iterator<Item = &dyn EnvCompleter> {
self.0.iter().copied()
}
}

/// Shell-integration for completions
Expand Down
Loading