Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI show config | display <format> exits over mountpoints with large YANGs #39

Closed
olofhagsand opened this issue Sep 16, 2023 · 3 comments
Closed

CLI show config | display <format> exits over mountpoints with large YANGs #39

olofhagsand opened this issue Sep 16, 2023 · 3 comments
Assignees
@krihal
Labels
bug Something isn't working fixed: plz verify Bug/feature is fixed by developer, need verification

Comments

@olofhagsand
Copy link
Member

In the cli, some show config | display xxx exits eg:

cli> show config
<devices xmlns="http://clicon.org/controller">
   <device>
   ....
cli>
cli> show config | display xml
cli>
@olofhagsand olofhagsand added bug Something isn't working performance CPU or memory optimization labels Sep 16, 2023
@olofhagsand olofhagsand changed the title CLI show config | display xxx exits over mountpoints with large YANGs CLI show config | display <format> exits over mountpoints with large YANGs Sep 16, 2023
@olofhagsand
Copy link
Member Author

After some investigation, there are several problems:

  1. The display command binds to YANG which triggers retreiving YANGs from the backend. This causes latency in some cases (large YANGs)
  2. There is a fixed timeout (few seconds) before the timeout which is triggered in this case.

Solution:

  1. The binding is necessary only for some formats, ie CLI, and should(maybe) also be cached?
  2. There should be no fixed timeout

@olofhagsand olofhagsand self-assigned this Sep 16, 2023
olofhagsand added a commit to clicon/cligen that referenced this issue Sep 16, 2023
@olofhagsand
Fixed: [CLI show config | display <format> exits over mountpoints wit…
750d349 
…h large YANGs](clicon/clixon-controller#39)
olofhagsand added a commit to clicon/clixon that referenced this issue Sep 16, 2023
@olofhagsand
Fixed: [CLI show config | display <format> exits over mountpoints wit…
35ad68f 
…h large YANGs](clicon/clixon-controller#39)
@olofhagsand olofhagsand added fixed: plz verify Bug/feature is fixed by developer, need verification and removed performance CPU or memory optimization labels Sep 16, 2023
@olofhagsand olofhagsand assigned krihal and unassigned olofhagsand Sep 16, 2023
@olofhagsand
Copy link
Member Author

Removed timeout and added a ^C

@krihal
Copy link
Collaborator

krihal commented Sep 23, 2023

Verified, I think.

@krihal krihal closed this as completed Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krihal krihal

Labels
bug Something isn't working fixed: plz verify Bug/feature is fixed by developer, need verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krihal @olofhagsand