Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI crash if error-info is empty #134

Closed
itzik-solomon opened this issue Sep 1, 2020 · 2 comments
Closed

CLI crash if error-info is empty #134

itzik-solomon opened this issue Sep 1, 2020 · 2 comments
Labels

Comments

@itzik-solomon
Copy link

if error-info is empty in rpc-error message, the CLI will crash from segmentation fault.
this does not happen with the other fields (error-type, error-tag, error-severity and error-message).

for example, replying with the following massage will crash:

<rpc-reply>
  <rpc-error>
    <error-type>aaa</error-type>
      <error-tag>aaa</error-tag>
      <error-info></error-info>              <---------empty
      <error-severity>aaa</error-severity>
      <error-message>aaa</error-message>
    </rpc-error>
</rpc-reply>

also, error-severity is not printed to the user.

@olofhagsand
Copy link
Member

Fixed by patch. Please verify.

@itzik-solomon
Copy link
Author

I will try to get to it tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants