Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support union with are same subtypes with SNMP #427

Merged
merged 15 commits into from
May 5, 2023
Merged

Support union with are same subtypes with SNMP #427

merged 15 commits into from
May 5, 2023

Conversation

StasSt-siklu
Copy link
Contributor

Support yang type union with are same subtypes with SNMP

@StasSt-siklu
Copy link
Contributor Author

Hi Olof.
Please check this PR.

@olofhagsand
Copy link
Member

olofhagsand commented Apr 21, 2023 •
edited
Loading

Looks good, thanks for the contribution.
Just please adapt to style guidelines in https://github.com/clicon/clixon/blob/master/CONTRIBUTING.md of the two functions is_same_subtypes_union() and yang_type_to_snmp().
This includes the style of function declarations , curly brackets not on next line (if () {), separate documents retvals(0 and 1)
Also seems test/test_snmp_union.sh has not execute bit set?

@olofhagsand
Copy link
Member

@StasSt-siklu may I ask why you close this PR, do you not want it merged?

@StasSt-siklu
Copy link
Contributor Author

Hi Olof. No. we want to merge this PR

@StasSt-siklu StasSt-siklu reopened this Apr 30, 2023
@StasSt-siklu
Copy link
Contributor Author

Good day Olof. Pls merge this PR

@olofhagsand olofhagsand merged commit 40f8dd1 into clicon:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StasSt-siklu @olofhagsand