Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add a way to say that certain data is stored in system state only and not in the clixon database #534

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Sep 27, 2024

  1. Add a way to report rpc-errors from a plugin

    Add plugin_rpc_err(), which works something like clixon_err, but it
    saves error information from a plugin for reporting rpc-errors that
    need to be returned.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    49b6e43 View commit details
    Browse the repository at this point in the history
  2. Add basic infrastructure for xmldb stateonly data

    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e97a27e View commit details
    Browse the repository at this point in the history
  3. Add an option to not store temporary databases on disk

    Don't store "candidate" or any other database except "running" on disk,
    only keep it in memory, if CLIXON_TMPDB_VOLATILE is true.  This, along
    with the stateonly handling, can be used to avoid storing sensitive
    data in the clixon databases.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    08e055a View commit details
    Browse the repository at this point in the history
  4. Start implementation of stateonly

    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    b412ea4 View commit details
    Browse the repository at this point in the history
  5. More work on stateonly

    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    81776ac View commit details
    Browse the repository at this point in the history
  6. Rework the stateonly add to take an XMl path

    Using a string for a path didn't work, when adding path elements to
    the tree using it you need to add a namespace in certain places.  So
    take an XML path instead and use the namespaces from that.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a5c9c6c View commit details
    Browse the repository at this point in the history
  7. Remove stateonly data from the startup database

    It can get there from the user or from defaults, but we don't want it.
    
    Also add some documentation on some functions.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    7fa46b3 View commit details
    Browse the repository at this point in the history
  8. Add some comments on stateonly, fix db issues with those calls

    If passing in an XML tree to the stateonly functions, completely ignore
    the database, don't do anything to it.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    e3dcba2 View commit details
    Browse the repository at this point in the history
  9. Fix issues with stateonly

    The database must be sorted afer reading in the data from xmldb or other
    operations won't work correctly.
    
    Add the stateonly data to the running database during a commit
    operation so the compare will work correclty.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c92581d View commit details
    Browse the repository at this point in the history
  10. stateonly: Don't remove the stateonly on a commit failure

    The data is expected to still be in the candidate database unless it is
    discarded, so don't delete it.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a3daabe View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. backend: Make sure candidate database gets cleaned properly on restconf

    The candidate commit function need to always clean the candidate
    database at the end.
    
    Signed-off-by: Corey Minyard <corey@minyard.net>
    cminyard committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    c0e8e11 View commit details
    Browse the repository at this point in the history