Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious "next" in lexicon_get_glob() #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbakker
Copy link

@sbakker sbakker commented Feb 28, 2018

When faced with a *DATA file glob, lexicon_get_glob() will:

  1. Walk the call stack, looking for the package that contains that *DATA glob.
  2. Open that module's source file.
  3. Skip up to and including the __DATA__ line.
  4. Read the rest of the input as the content to parse.

... Except that step 1 doesn't work. Due to an unqualified next statement, it was just basically running an empty loop.

The result was that the below would just never work:

use Locale::Maketext::Lexicon( Gettext => \*DATA );

This made me sad.

When faced with a *DATA file glob, lexicon_get_glob()
will:

    1 Walk the call stack, looking for the package that
      contains that *DATA glob.
    2 Open that module's source file.
    3 Skip up to and including the __DATA__ line.
    4 Read the rest of the input as the content to parse.

... Except that step 1 doesn't work. Due to an unqualified "next"
statement, it was just basically running an empty loop.

The result was that the below would just never work:

    use Locale::Maketext::Lexicon( Gettext => \*DATA );

This made me sad.
@sbakker
Copy link
Author

sbakker commented Oct 17, 2018

Is this module still maintained, or is it abandoned?

@clintongormley
Copy link
Owner

I no longer have the time to maintain this module. I was never the owner, just the co-maintainer, and as such am unable to put the module up for adoption. You could contact AUDREYT if you are interested in taking over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants