Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cluster-admin ClusterRoleBinding #763

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

rsevilla87
Copy link
Member

Signed-off-by: Raul Sevilla rsevilla@redhat.com

Description

I think it's better to use a cluster-admin ClusterRole. At the moment it's difficult to manage the permissions required by most of benchmarks.
Some of them already have privileged permissions, their own Roles/Bindings files, etc. We should reduce the amount of things we manage.

I know this is not a security-friendly practice, but running performance benchmarks in a cluster is 99% of cases executed by a cluster's administrator

This should simplify the things a little bit.

Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the slew of failed tests. Not sure those are actually related to this change :-/

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@61f325e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #763   +/-   ##
=========================================
  Coverage          ?   53.47%           
=========================================
  Files             ?        8           
  Lines             ?      331           
  Branches          ?        0           
=========================================
  Hits              ?      177           
  Misses            ?      154           
  Partials          ?        0           
Flag Coverage Δ
gha 53.47% <0.00%> (?)
python-3.9 53.47% <0.00%> (?)
unit 53.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f325e...e15c19f. Read the comment docs.

@rsevilla87 rsevilla87 force-pushed the cluster-admin branch 2 times, most recently from 446a0b5 to e8fc709 Compare June 6, 2022 09:50
permissions issues

Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
@rsevilla87 rsevilla87 merged commit f4fe8fb into cloud-bulldozer:master Jun 7, 2022
@rsevilla87 rsevilla87 deleted the cluster-admin branch June 7, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants