-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cluster-admin ClusterRoleBinding #763
Conversation
f24d249
to
2fa12e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minus the slew of failed tests. Not sure those are actually related to this change :-/
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
=========================================
Coverage ? 53.47%
=========================================
Files ? 8
Lines ? 331
Branches ? 0
=========================================
Hits ? 177
Misses ? 154
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
446a0b5
to
e8fc709
Compare
permissions issues Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Signed-off-by: Raul Sevilla <rsevilla@redhat.com>
Signed-off-by: Raul Sevilla rsevilla@redhat.com
Description
I think it's better to use a cluster-admin ClusterRole. At the moment it's difficult to manage the permissions required by most of benchmarks.
Some of them already have privileged permissions, their own Roles/Bindings files, etc. We should reduce the amount of things we manage.
I know this is not a security-friendly practice, but running performance benchmarks in a cluster is 99% of cases executed by a cluster's administrator
This should simplify the things a little bit.