added uperf to run from run_snafu --tool #138

amitsagtani97 · 2020-02-13T13:27:01Z

Depends-On: 283

rht-perf-ci · 2020-02-13T13:29:05Z

Can one of the admins verify this patch?

aakarshg · 2020-02-13T15:09:37Z

/rerun all

rht-perf-ci · 2020-02-13T16:48:09Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:12:41
fs_drift_wrapper	PASS	00:09:58
hammerdb	FAIL	00:16:38
iperf	PASS	00:06:09
pgbench-wrapper	PASS	00:07:31
smallfile_wrapper	PASS	00:12:03
sysbench	PASS	00:05:20
uperf_wrapper	FAIL	00:07:17
ycsb-wrapper	PASS	00:14:18

uperf_wrapper/trigger_uperf.py

aakarshg · 2020-02-13T22:10:02Z

uperf_wrapper/trigger_uperf.py

+
+class Trigger_uperf():
+    def __init__(self, args):
+        stdout = self._run_uperf(args.workload[0])


I think all of this will need to move to a new function called emit_actions(), you can take a look at https://github.com/cloud-bulldozer/snafu/blob/master/run_snafu.py#L119 and that's why the comment below about yield documents and the index...

aakarshg

Posted comments also CI will keep failing until we update how we run the test in ripsaw as the snafu ci uses ripsaw !

uperf_wrapper/trigger_uperf.py

uperf_wrapper/uperf_wrapper.py

aakarshg · 2020-02-20T16:15:23Z

/rerun all

rht-perf-ci · 2020-02-20T18:04:26Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:13:04
fs_drift_wrapper	PASS	00:10:39
hammerdb	FAIL	00:16:42
iperf	PASS	00:06:26
pgbench-wrapper	PASS	00:07:33
smallfile_wrapper	PASS	00:12:01
sysbench	PASS	00:05:16
uperf_wrapper	FAIL	00:08:14
ycsb-wrapper	PASS	00:12:43

aakarshg · 2020-02-24T15:22:45Z

/rerun all

rht-perf-ci · 2020-02-24T21:04:02Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:13:15
fs_drift_wrapper	PASS	00:10:49
hammerdb	FAIL	00:16:58
iperf	PASS	00:06:22
pgbench-wrapper	PASS	00:08:02
smallfile_wrapper	PASS	00:12:27
sysbench	PASS	00:05:24
uperf_wrapper	FAIL	00:10:12
ycsb-wrapper	PASS	00:16:28

aakarshg · 2020-02-25T17:01:11Z

/rerun all

rht-perf-ci · 2020-02-25T18:45:53Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:13:18
fs_drift_wrapper	PASS	00:10:27
hammerdb	FAIL	00:16:59
iperf	PASS	00:06:16
pgbench-wrapper	PASS	00:08:01
smallfile_wrapper	PASS	00:11:52
sysbench	PASS	00:05:27
uperf_wrapper	FAIL	00:10:17
ycsb-wrapper	PASS	00:15:49

uperf_wrapper/trigger_uperf.py

aakarshg · 2020-02-26T14:46:04Z

/rerun all

aakarshg · 2020-02-26T16:35:43Z

/rerun all

rht-perf-ci · 2020-02-26T16:37:03Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:12:52
fs_drift_wrapper	PASS	00:10:29
hammerdb	FAIL	00:17:02
iperf	PASS	00:06:45
pgbench-wrapper	PASS	00:07:33
smallfile_wrapper	PASS	00:13:33
sysbench	PASS	00:05:46
uperf_wrapper	FAIL	00:10:20
ycsb-wrapper	PASS	00:20:52

dry923

LGTM

aakarshg

The documents in elasticsearch are missing user and client_ips field

jtaleric · 2020-03-26T11:51:26Z

The documents in elasticsearch are missing user and client_ips field

Looking at the code, I don't see how this can be?
Was the user passed?
Did UPerf run and somehow we didn't capture the clients?

amitsagtani97 · 2020-03-27T14:55:10Z

@jtaleric The user was exported in the environment variable but it wasn't found when fetched by the uperf. We tried to pass the user and client_ips as argument

run_snafu --tool -user {{test_user | default("ripsaw") }} -client_ips $(hostname -I)

Here the user was sent correctly but the client_ip wasn't sent.
and the rest of the data was saved in the ElasticSearch. Also, the CI test passed because we fetch results on elastic by index and uuid only.

python3 ci/check_es.py -s marquez.perf.lab.eng.rdu2.redhat.com -p 9200 -u b0065619-ee93-527c-b1e1-f208e14c1f0b -i ripsaw-uperf-results

aakarshg · 2020-03-31T15:09:55Z

/rerun all

rht-perf-ci · 2020-03-31T18:01:52Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:16:42
fs_drift_wrapper	PASS	00:09:39
hammerdb	FAIL	00:17:01
iperf	PASS	00:07:12
pgbench-wrapper	PASS	00:07:27
smallfile_wrapper	PASS	00:11:12
sysbench	PASS	00:04:56
uperf_wrapper	PASS	00:25:44
ycsb_wrapper	FAIL	00:17:41

aakarshg · 2020-03-31T21:17:08Z

/rerun all

rht-perf-ci · 2020-04-01T00:57:53Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:16:08
fs_drift_wrapper	FAIL	00:09:39
hammerdb	PASS	00:11:18
iperf	PASS	00:06:53
pgbench-wrapper	PASS	00:07:20
smallfile_wrapper	PASS	00:11:26
sysbench	PASS	00:05:14
uperf_wrapper	PASS	00:25:01
ycsb_wrapper	PASS	00:12:56

aakarshg · 2020-04-06T12:50:49Z

/rerun all

rht-perf-ci · 2020-04-06T15:54:00Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	FAIL	00:02:20
fs_drift_wrapper	FAIL	00:02:00
hammerdb	FAIL	00:03:11
iperf	FAIL	00:00:50
pgbench-wrapper	FAIL	00:02:13
smallfile_wrapper	FAIL	00:02:26
sysbench	FAIL	00:00:59
uperf_wrapper	FAIL	00:02:06
ycsb_wrapper	FAIL	00:08:54

aakarshg · 2020-04-06T17:07:01Z

/rerun all

rht-perf-ci · 2020-04-06T21:24:42Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	FAIL	00:31:49
fs_drift_wrapper	FAIL	00:10:20
hammerdb	PASS	00:11:18
iperf	PASS	00:06:59
pgbench-wrapper	PASS	00:07:41
smallfile_wrapper	PASS	00:10:58
sysbench	PASS	00:04:56
uperf_wrapper	PASS	00:25:11
ycsb_wrapper	PASS	00:13:34

aakarshg · 2020-04-09T19:41:24Z

/rerun all

rht-perf-ci · 2020-04-09T19:59:24Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	FAIL	00:09:33

dry923 · 2020-04-09T20:28:49Z

/rerun all

rht-perf-ci · 2020-04-09T20:37:14Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	FAIL	00:07:03

aakarshg · 2020-04-13T01:20:39Z

/rerun all

rht-perf-ci · 2020-04-13T03:33:27Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	FAIL	00:12:09
fs_drift_wrapper	FAIL	00:07:48
hammerdb	PASS	00:08:20
iperf	PASS	00:04:54
pgbench-wrapper	PASS	00:04:25
smallfile_wrapper	PASS	00:07:21
sysbench	PASS	00:03:21
uperf_wrapper	FAIL	00:30:30
ycsb_wrapper	PASS	00:09:18

aakarshg · 2020-04-15T21:42:14Z

/rerun all

rht-perf-ci · 2020-04-16T00:01:52Z

Results for SNAFU CI Test

Test	Result	Runtime
fio_wrapper	PASS	00:10:26
fs_drift_wrapper	PASS	00:07:05
hammerdb	PASS	00:07:48
iperf	PASS	00:04:45
pgbench-wrapper	PASS	00:04:31
smallfile_wrapper	PASS	00:07:42
sysbench	PASS	00:03:27
uperf_wrapper	PASS	00:18:44
ycsb_wrapper	PASS	00:10:56

aakarshg

Everything looks good now with the PR

jtaleric requested review from aakarshg and jtaleric February 13, 2020 13:36

jtaleric added the ok to test Kick off our CI framework label Feb 13, 2020

aakarshg reviewed Feb 13, 2020

View reviewed changes

uperf_wrapper/trigger_uperf.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 13, 2020

View reviewed changes

uperf_wrapper/trigger_uperf.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 13, 2020

View reviewed changes

aakarshg suggested changes Feb 13, 2020

View reviewed changes

jtaleric mentioned this pull request Feb 14, 2020

updated uperf to run_snafu and underscores #55

Closed

aakarshg reviewed Feb 17, 2020

View reviewed changes

uperf_wrapper/trigger_uperf.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 17, 2020

View reviewed changes

uperf_wrapper/trigger_uperf.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 17, 2020

View reviewed changes

uperf_wrapper/trigger_uperf.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 17, 2020

View reviewed changes

uperf_wrapper/uperf_wrapper.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 17, 2020

View reviewed changes

uperf_wrapper/uperf_wrapper.py Outdated Show resolved Hide resolved

amitsagtani97 mentioned this pull request Feb 18, 2020

Updated ci test for uperf to support --tool migration cloud-bulldozer/benchmark-operator#283

Merged

jtaleric requested a review from aakarshg February 18, 2020 20:25

aakarshg reviewed Feb 19, 2020

View reviewed changes

uperf_wrapper/uperf_wrapper.py Outdated Show resolved Hide resolved

aakarshg reviewed Feb 25, 2020

View reviewed changes

uperf_wrapper/trigger_uperf.py Outdated Show resolved Hide resolved

dry923 approved these changes Feb 26, 2020

View reviewed changes

aakarshg suggested changes Mar 19, 2020

View reviewed changes

jtaleric self-requested a review March 26, 2020 11:52

amitsagtani97 added 8 commits April 16, 2020 02:47

added uperf to run from run_snafu --tool

a53990a

added emit_action method

5c3b020

removed indexing from trigger_uperf

43ee2c2

code cleaning

7f85f0a

removed es checks

b3d8b61

fixed passing each document

bc1f283

updated uuid value

c25fae7

get user from argument of run_snafu

c2b00a9

aakarshg approved these changes Apr 16, 2020

View reviewed changes

aakarshg merged commit 4143f16 into cloud-bulldozer:master Apr 16, 2020

added uperf to run from run_snafu --tool #138

added uperf to run from run_snafu --tool #138

Conversation

amitsagtani97 commented Feb 13, 2020 • edited Loading

rht-perf-ci commented Feb 13, 2020

aakarshg commented Feb 13, 2020

rht-perf-ci commented Feb 13, 2020

aakarshg Feb 13, 2020

Choose a reason for hiding this comment

aakarshg left a comment

Choose a reason for hiding this comment

aakarshg commented Feb 20, 2020

rht-perf-ci commented Feb 20, 2020

aakarshg commented Feb 24, 2020

rht-perf-ci commented Feb 24, 2020

aakarshg commented Feb 25, 2020

rht-perf-ci commented Feb 25, 2020

aakarshg commented Feb 26, 2020

aakarshg commented Feb 26, 2020

rht-perf-ci commented Feb 26, 2020

dry923 left a comment

Choose a reason for hiding this comment

aakarshg left a comment

Choose a reason for hiding this comment

jtaleric commented Mar 26, 2020 • edited Loading

amitsagtani97 commented Mar 27, 2020

aakarshg commented Mar 31, 2020

rht-perf-ci commented Mar 31, 2020

aakarshg commented Mar 31, 2020

rht-perf-ci commented Apr 1, 2020

aakarshg commented Apr 6, 2020

rht-perf-ci commented Apr 6, 2020

aakarshg commented Apr 6, 2020

rht-perf-ci commented Apr 6, 2020

aakarshg commented Apr 9, 2020

rht-perf-ci commented Apr 9, 2020

dry923 commented Apr 9, 2020

rht-perf-ci commented Apr 9, 2020

aakarshg commented Apr 13, 2020

rht-perf-ci commented Apr 13, 2020

aakarshg commented Apr 15, 2020

rht-perf-ci commented Apr 16, 2020

aakarshg left a comment

Choose a reason for hiding this comment

amitsagtani97 commented Feb 13, 2020 •

edited

Loading

jtaleric commented Mar 26, 2020 •

edited

Loading