-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing full test trigger to properly handle file changes in the root dir #157
Conversation
Results for SNAFU CI Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dry923 I think there's a easier solution for this issue that consists in just double quoting the ${diff_list}
variable.
Example here:
$ diff_list=`git diff origin/master --name-only`
$ echo ${diff_list} | grep -cv /
0
echo "${diff_list}" | grep -cv /
1
# Double quoting, basically prints the original value of the variable
$ echo ${diff_list}
ci/run_ci.sh run_snafu.py smallfile_wrapper/README.md smallfile_wrapper/smallfile_wrapper.py smallfile_wrapper/sync-diagram.png smallfile_wrapper/trigger_smallfile.py
$ echo "${diff_list}"
ci/run_ci.sh
run_snafu.py
smallfile_wrapper/README.md
smallfile_wrapper/smallfile_wrapper.py
smallfile_wrapper/sync-diagram.png
smallfile_wrapper/trigger_smallfile.py
What do you think?
I like it. Good thinking @rsevilla87 . Let me update |
3d69a81
to
f3520b3
Compare
Results for SNAFU CI Test
|
Results for SNAFU CI Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Previously the full test trigger was not being properly executed if a file was changed in the root of the snafu directory. This fixes that.