Bump to fio-3.19 #166
Bump to fio-3.19 #166
Conversation
|
Results for SNAFU CI Test
|
|
/rerun all |
|
Results for SNAFU CI Test
|
|
Results for SNAFU CI Test
|
| @@ -128,7 +128,7 @@ def _log_payload(self, directory, user, uuid, sample, fio_jobs_dict, fio_version | |||
| with open(directory + '/' + str(log_file_name), 'r') as log_file: | |||
| for log_line in log_file: | |||
| log_line_values = str(log_line).split(", ") | |||
| if len(log_line_values) == 4: | |||
| if len(log_line_values) == 5: | |||
There was a problem hiding this comment.
Do we want to have some backwards compatibility or simply state we support fio-3.19 (for now)... Since this won'w work with earlier versions?
There was a problem hiding this comment.
I guess this would be required in case of executing Snafu out from the Ripsaw context. Is that what you're thinking?
There was a problem hiding this comment.
My thoughts exactly... We could capture the version via fio --version to determine the code path... Or simply document we only support X version... I am not against either.
There was a problem hiding this comment.
After the discussion on our weekly tooling/automation call i think the pr in its current state is looking good apart from the minor nit with git. We'll still need to document the version of each benchmark we're using but that can be deferred to a subsequent pr.
| COPY --from=builder /fio-fio-3.12/fio /usr/local/bin/fio | ||
| RUN dnf install -y --nodocs git python3-pip python3-requests python3-numpy libaio zlib procps-ng iproute net-tools ethtool nmap iputils && dnf clean all | ||
| COPY --from=builder /fio-fio-3.19/fio /usr/local/bin/fio | ||
| RUN dnf install -y --nodocs python3-pip python3-requests python3-numpy libaio zlib procps-ng iproute net-tools ethtool nmap iputils && dnf clean all |
There was a problem hiding this comment.
as @dry923 pointed out about the missing git ? ci passed fine so maybe its installed by default on ubi8?
There was a problem hiding this comment.
I don't know why git was there. It's not required to run the workload.
There was a problem hiding this comment.
it was there because of the old way of cloning snafu, now we dont clone snafu anymore we just copy it
Depends-On: 310