Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve and clean-up Fio code #168

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Improve and clean-up Fio code #168

merged 1 commit into from
Apr 27, 2020

Conversation

rsevilla87
Copy link
Member

Improve Fio code with more log messages, better exception handling and code optimizations.

@rsevilla87 rsevilla87 added the ok to test Kick off our CI framework label Apr 15, 2020
@rht-perf-ci
Copy link

Results for SNAFU CI Test

Test Result Runtime
fio_wrapper FAIL 00:09:36
fs_drift_wrapper FAIL 00:07:32
hammerdb PASS 00:07:42
iperf PASS 00:04:35
pgbench-wrapper PASS 00:04:47
smallfile_wrapper PASS 00:09:03
sysbench PASS 00:03:38
uperf-wrapper PASS 00:18:31
ycsb_wrapper PASS 00:11:30

@rht-perf-ci
Copy link

Results for SNAFU CI Test

Test Result Runtime
fio_wrapper PASS 00:10:29
fs_drift_wrapper PASS 00:07:00
hammerdb PASS 00:08:02
iperf PASS 00:05:19
pgbench-wrapper PASS 00:04:47
smallfile_wrapper PASS 00:08:14
sysbench PASS 00:03:21
uperf-wrapper PASS 00:19:01
ycsb_wrapper PASS 00:11:02

@dry923
Copy link
Member

dry923 commented Apr 17, 2020

@rsevilla87 rebase please

@rht-perf-ci
Copy link

Results for SNAFU CI Test

Test Result Runtime
fio_wrapper PASS 00:10:47
fs_drift_wrapper PASS 00:07:04
hammerdb PASS 00:07:43
iperf PASS 00:04:27
pgbench_wrapper PASS 00:03:54
smallfile_wrapper PASS 00:06:51
sysbench PASS 00:02:47
uperf_wrapper PASS 00:18:11
ycsb_wrapper PASS 00:09:13

dry923
dry923 approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bengland2
bengland2 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@bengland2 bengland2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a lot more bulletproof, more maintainable (leveraging self.) and catches CLI errors early at parse time, I like it. Thanks.

run_snafu.py
parser.add_argument(
'-v', '--verbose', action='store_const', dest='loglevel', const=logging.DEBUG,
default=logging.INFO, help='enables verbose wrapper debugging info')
parser.add_argument(
'-t', '--tool', help='Provide tool name')
'-t', '--tool', help='Provide tool name', required=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, catch mistakes as early as possible.

@bengland2
Copy link
Contributor

I'm running this PR on my laptop using minikube and still getting the same error from fio, no indication of why it happens:

2020-04-21T19:54:33Z - ERROR    - MainProcess - trigger_fio: Fio failed to execute, trying one more time..
2020-04-21T19:54:34Z - ERROR    - MainProcess - trigger_fio: Fio failed to execute a second time, stopping...
2020-04-21T19:54:34Z - ERROR    - MainProcess - trigger_fio: (b'', 1)

where does this last message even come from?

@bengland2
Copy link
Contributor

never mind that last comment, I was using the wrong snafu, I used yours and now I get a clear idea of what was wrong:

2020-04-22T17:24:20Z - ERROR    - MainProcess - trigger_fio: Fio failed to execute
2020-04-22T17:24:20Z - ERROR    - MainProcess - trigger_fio: Output file: <fio-server-1-benchmark-d0ea5d9f-dk7
qt> fio: output file open error: No such file or directory
<fio-server-2-benchmark-d0ea5d9f-6hvmj> fio: output file open error: No such file or directory

@aakarshg
Copy link
Contributor

can you please rebase @rsevilla87

@rht-perf-ci
Copy link

Results for SNAFU CI Test

Test Result Runtime
fio_wrapper PASS 00:17:24
fs_drift_wrapper PASS 00:07:09
hammerdb PASS 00:07:23
iperf PASS 00:04:27
pgbench_wrapper PASS 00:04:10
smallfile_wrapper PASS 00:06:42
sysbench PASS 00:03:03
uperf_wrapper PASS 00:18:39
ycsb_wrapper PASS 00:11:13

aakarshg
aakarshg approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@aakarshg aakarshg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aakarshg aakarshg merged commit f733771 into cloud-bulldozer:master Apr 27, 2020
@fritchie fritchie mentioned this pull request Dec 3, 2020
Closed
@rsevilla87 rsevilla87 deleted the fio-cleanup branch April 6, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengland2 bengland2 bengland2 approved these changes

@aakarshg aakarshg aakarshg approved these changes

@dry923 dry923 dry923 approved these changes

Assignees
No one assigned
Labels
ok to test Kick off our CI framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rsevilla87 @rht-perf-ci @dry923 @bengland2 @aakarshg