Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop cache #196

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Drop cache #196

merged 10 commits into from
Aug 12, 2020

Conversation

bengland2
Copy link
Contributor

This change would enable snafu benchmarks to utilize privileged cache-dropper pods as a cherrypy web service with well-known TCP ports. run_snafu.py would invoke drop_cache() before every sample. The ripsaw component of the benchmark would start cache dropper pods and then would wait until they were running, then get their IP addresses and pass them as environment variables into run_snafu.py. It was tested using minikube - run_snafu has to be run within a k8s pod to be able to talk to cache-dropper pod.

run_snafu.py Outdated Show resolved Hide resolved
@bengland2
Copy link
Contributor Author

evidence that it works

@rsevilla87 rsevilla87 self-requested a review July 29, 2020 09:50
also fix bugs in ceph cache dropping code (not implemented yet)
do not hardcode either kernel or ceph cache dropping ports
@rsevilla87
Copy link
Member

Hey @bengland2, can you rebase please?

@bengland2
Copy link
Contributor Author

@rsevilla87 I rebased, what do you think?

@jtaleric jtaleric added the ok to test Kick off our CI framework label Aug 10, 2020
@jtaleric
Copy link
Member

/rerun all

@bengland2
Copy link
Contributor Author

am cleaning up the lint errors now, will rerun afterwards. My bad, forgot to run pycodestyle

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
src/fio_wrapper PASS 00:13:23
src/fs_drift_wrapper PASS 00:08:41
src/hammerdb PASS 00:07:00
src/iperf PASS 00:06:25
src/pgbench_wrapper PASS 00:05:12
src/smallfile_wrapper PASS 00:09:24
src/sysbench PASS 00:03:09
src/uperf_wrapper PASS 00:27:23
src/vegeta_wrapper PASS 00:08:21
src/ycsb_wrapper PASS 00:08:38

@bengland2
Copy link
Contributor Author

actually the linter found bugs, so worth the effort, retesting with changes, then will re-CI it, then will merge.

@bengland2
Copy link
Contributor Author

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
src/fio_wrapper PASS 00:13:56
src/fs_drift_wrapper PASS 00:08:51
src/hammerdb PASS 00:07:11
src/iperf PASS 00:05:54
src/pgbench_wrapper PASS 00:05:09
src/smallfile_wrapper PASS 00:09:04
src/sysbench FAIL 00:03:11
src/uperf_wrapper PASS 00:26:50
src/vegeta_wrapper PASS 00:08:09
src/ycsb_wrapper PASS 00:08:15

@bengland2
Copy link
Contributor Author

I'm not buying that this particular PR broke only sysbench and nothing else. Merging it. It does run fio.

@bengland2 bengland2 merged commit b5e086e into cloud-bulldozer:master Aug 12, 2020
@jtaleric
Copy link
Member

22:21:22 Logs from sysbench-1ecb6eab-sc4xt
22:21:22 ++ kubectl -n my-ripsaw-6c45a80f-3f6b-446e-8cc4-48a4e978585b logs --tail=40 sysbench-1ecb6eab-sc4xt
22:21:22 Error from server (BadRequest): container "sysbench" in pod "sysbench-1ecb6eab-sc4xt" is waiting to start: PodInitializing
22:21:22 +++ error```

I am curious, most of our other CI has retries, but it looks like SNAFU does not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants