Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated fio wrapper to trigger prom collection #206

Merged
merged 1 commit into from
Oct 27, 2020
Merged

updated fio wrapper to trigger prom collection #206

merged 1 commit into from
Oct 27, 2020

Conversation

acalhounRH
Copy link
Contributor

@acalhounRH acalhounRH commented Sep 3, 2020 •
edited
Loading

This PR updates snafu to enable the collection and porting of OCP Prometheus data to Elasticsearch when using the fio wrapper

@jtaleric
@dry923
@rsevilla87
@bengland2

@acalhounRH
Copy link
Contributor Author

Sample dashboards:

AWS FIO Summary with rook-ceph ES-Backed
Instance View Dashboard - ES Backed
Ceph - Cluster ES Backed

@jtaleric jtaleric added the ok to test Kick off our CI framework label Sep 23, 2020
@jtaleric
Copy link
Member

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:06:39
snafu/ycsb_wrapper PASS 00:07:51
snafu/pgbench_wrapper PASS 00:05:00
snafu/uperf_wrapper FAIL 00:20:50
snafu/iperf PASS 00:07:26
snafu/sysbench PASS 00:02:34
snafu/vegeta_wrapper FAIL 00:11:50
snafu/scale_openshift_wrapper PASS 00:10:24
snafu/hammerdb PASS 00:06:52
snafu/fs_drift_wrapper PASS 00:07:04
snafu/smallfile_wrapper PASS 00:07:29

rsevilla87
rsevilla87 requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments

@rsevilla87
Copy link
Member

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:07:03
snafu/ycsb_wrapper PASS 00:07:21
snafu/pgbench_wrapper PASS 00:05:11
snafu/uperf_wrapper PASS 00:23:40
snafu/iperf PASS 00:07:12
snafu/sysbench PASS 00:02:32
snafu/stressng_wrapper FAIL 00:02:03
snafu/vegeta_wrapper PASS 00:07:04
snafu/scale_openshift_wrapper PASS 00:11:13
snafu/hammerdb PASS 00:07:23
snafu/fs_drift_wrapper PASS 00:07:33
snafu/smallfile_wrapper PASS 00:07:58

@acalhounRH
Copy link
Contributor Author

Fio failed due to triggering Prometheus collections without setting prom CR parameters.

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:13:44
snafu/ycsb_wrapper FAIL 00:07:22
snafu/pgbench_wrapper FAIL 00:06:44
snafu/uperf_wrapper FAIL 00:14:13
snafu/iperf FAIL 00:10:57
snafu/sysbench PASS 00:02:37
snafu/stressng_wrapper FAIL 00:02:21
snafu/vegeta_wrapper FAIL 00:05:05
snafu/scale_openshift_wrapper FAIL 00:04:10
snafu/hammerdb FAIL 00:07:03
snafu/fs_drift_wrapper FAIL 00:04:58
snafu/smallfile_wrapper FAIL 00:05:31

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:05:47
snafu/ycsb_wrapper FAIL 00:11:10
snafu/pgbench_wrapper PASS 00:04:51
snafu/uperf_wrapper FAIL 00:06:39
snafu/iperf PASS 00:07:27
snafu/sysbench PASS 00:02:39
snafu/stressng_wrapper FAIL 00:12:08
snafu/vegeta_wrapper FAIL 00:11:46
snafu/scale_openshift_wrapper FAIL 00:03:41
snafu/hammerdb PASS 00:06:51
snafu/fs_drift_wrapper FAIL 00:05:44
snafu/smallfile_wrapper FAIL 00:05:52

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper PASS 00:22:13
snafu/ycsb_wrapper PASS 00:07:36
snafu/pgbench_wrapper PASS 00:05:08
snafu/uperf_wrapper PASS 00:23:29
snafu/iperf PASS 00:07:23
snafu/sysbench PASS 00:03:00
snafu/stressng_wrapper PASS 00:04:39
snafu/vegeta_wrapper PASS 00:06:57
snafu/scale_openshift_wrapper PASS 00:10:48
snafu/hammerdb PASS 00:07:57
snafu/fs_drift_wrapper PASS 00:07:17
snafu/smallfile_wrapper PASS 00:07:41

rsevilla87
rsevilla87 approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@rsevilla87 rsevilla87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

dry923
dry923 reviewed Oct 20, 2020
View reviewed changes
snafu/run_snafu.py Outdated Show resolved Hide resolved
@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:14:09
snafu/ycsb_wrapper FAIL 00:06:57
snafu/pgbench_wrapper FAIL 00:06:00
snafu/uperf_wrapper FAIL 00:14:02
snafu/iperf FAIL 00:12:52
snafu/sysbench PASS 00:02:29
snafu/stressng_wrapper FAIL 00:04:38
snafu/vegeta_wrapper FAIL 00:04:51
snafu/scale_openshift_wrapper FAIL 00:03:50
snafu/hammerdb FAIL 00:06:59
snafu/fs_drift_wrapper FAIL 00:04:48
snafu/smallfile_wrapper FAIL 00:05:10

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:14:00
snafu/ycsb_wrapper FAIL 00:07:21
snafu/pgbench_wrapper FAIL 00:06:01
snafu/uperf_wrapper FAIL 00:14:09
snafu/iperf FAIL 00:11:02
snafu/sysbench PASS 00:02:37
snafu/stressng_wrapper FAIL 00:04:44
snafu/vegeta_wrapper FAIL 00:05:06
snafu/scale_openshift_wrapper FAIL 00:03:59
snafu/hammerdb FAIL 00:07:50
snafu/fs_drift_wrapper FAIL 00:04:58
snafu/smallfile_wrapper FAIL 00:05:12

@dry923
Copy link
Member

dry923 commented Oct 22, 2020

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper PASS 00:22:07
snafu/ycsb_wrapper PASS 00:06:54
snafu/pgbench_wrapper PASS 00:05:05
snafu/uperf_wrapper PASS 00:21:30
snafu/iperf PASS 00:06:49
snafu/sysbench PASS 00:02:28
snafu/stressng_wrapper PASS 00:04:17
snafu/vegeta_wrapper PASS 00:06:35
snafu/scale_openshift_wrapper PASS 00:06:43
snafu/hammerdb PASS 00:08:58
snafu/fs_drift_wrapper PASS 00:07:42
snafu/smallfile_wrapper PASS 00:07:23

jtaleric
jtaleric approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should we look to add a test?

dry923
dry923 approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dry923 dry923 merged commit ab94b45 into cloud-bulldozer:master Oct 27, 2020
@acalhounRH acalhounRH deleted the add_prom_collection_for_fio branch November 18, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portante portante portante left review comments

@jtaleric jtaleric jtaleric approved these changes

@rsevilla87 rsevilla87 rsevilla87 approved these changes

@dry923 dry923 dry923 approved these changes

@bengland2 bengland2 Awaiting requested review from bengland2

@mohit-sheth mohit-sheth Awaiting requested review from mohit-sheth

Assignees
No one assigned
Labels
ok to test Kick off our CI framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acalhounRH @jtaleric @comet-perf-ci @rsevilla87 @dry923 @portante