corrected if statement on bs||bsrange check #210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incorrectly used bool(dict) which triggered a keyerror when bs || bsrange were null, instead the proper method to check if a key is within a dict is dict.get(key).
Have ran though multiple dry runs and captured valid results, please see link below.
http://marquez.perf.lab.eng.rdu2.redhat.com:3000/d/QdOBqFNGk/fio-summary-with-rook-ceph?orgId=1&from=now-30m&to=now&var-user=acalhoun&var-clustername=acalhoun-ocs-aws-compression-test-1&var-UUID=ffe9f52f-a72d-5400-a2ed-136c072ab2a9&var-Operation=write&var-io_size=1KiB-16KiB&var-io_size=32KiB-256KiB&var-io_size=512KiB-4096KiB&var-interval=$__auto_interval_interval&var-datasource=Alex%20Prometheus%20Remote%20Write&var-net_device=$__all&var-block_device=$__all&var-instances=$__all&var-ceph_pod=$__all