Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected if statement on bs||bsrange check #210

Merged

Conversation

Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for bsrange to [1] to ensure we test this code path?

[1] https://github.com/cloud-bulldozer/benchmark-operator/blob/master/tests/test_crs/valid_fiod.yaml

@acalhounRH
Copy link
Contributor Author

/rerun all

1 similar comment
@jtaleric
Copy link
Member

/rerun all

@jtaleric jtaleric self-requested a review September 11, 2020 16:30
@jtaleric jtaleric added the ok to test Kick off our CI framework label Sep 11, 2020
@jtaleric
Copy link
Member

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper FAIL 00:10:24
snafu/ycsb_wrapper PASS 00:06:49
snafu/pgbench_wrapper PASS 00:04:54
snafu/uperf_wrapper PASS 00:20:23
snafu/iperf PASS 00:03:40
snafu/sysbench PASS 00:02:42
snafu/vegeta_wrapper PASS 00:06:44
snafu/hammerdb PASS 00:06:37
snafu/fs_drift_wrapper PASS 00:07:19
snafu/smallfile_wrapper PASS 00:07:18

@jtaleric
Copy link
Member

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper PASS 00:17:40
snafu/ycsb_wrapper PASS 00:06:57
snafu/pgbench_wrapper PASS 00:04:39
snafu/uperf_wrapper PASS 00:20:23
snafu/iperf PASS 00:03:42
snafu/sysbench PASS 00:02:34
snafu/vegeta_wrapper PASS 00:06:43
snafu/hammerdb PASS 00:06:50
snafu/fs_drift_wrapper PASS 00:07:00
snafu/smallfile_wrapper PASS 00:07:17

@jtaleric jtaleric merged commit 4459639 into cloud-bulldozer:master Sep 14, 2020
@acalhounRH acalhounRH deleted the buxfix_handle_bsrange_fio_wrapper branch September 14, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants