Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed / from path in order to resolve relative path to utils #232

Merged
merged 1 commit into from
Nov 19, 2020
Merged

removed / from path in order to resolve relative path to utils #232

merged 1 commit into from
Nov 19, 2020

Conversation

acalhounRH
Copy link
Contributor

No description provided.

@dry923
Copy link
Member

dry923 commented Nov 19, 2020

Pre change:

>>> print(os.path.join(dirname, '/utils/prometheus_labels/'))
/utils/prometheus_labels/>>> print(os.path.join(dirname, '/utils/prometheus_labels/'))
/utils/prometheus_labels/

Post change:

>>> print(os.path.join(dirname, 'utils/prometheus_labels/'))
/tmp/test/snafu/snafu/utils/prometheus_labels/

dry923
dry923 approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chaitanyaenr
chaitanyaenr approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dry923 dry923 added the ok to test Kick off our CI framework label Nov 19, 2020
@dry923
Copy link
Member

dry923 commented Nov 19, 2020

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fio_wrapper PASS 00:24:00
snafu/ycsb_wrapper PASS 00:07:22
snafu/pgbench_wrapper PASS 00:04:38
snafu/uperf_wrapper PASS 00:27:39
snafu/iperf PASS 00:06:33
snafu/sysbench PASS 00:02:15
snafu/stressng_wrapper PASS 00:04:14
snafu/vegeta_wrapper PASS 00:06:27
snafu/scale_openshift_wrapper PASS 00:11:00
snafu/upgrade_openshift_wrapper PASS 00:00:00
snafu/hammerdb PASS 00:06:31
snafu/fs_drift_wrapper PASS 00:06:20
snafu/smallfile_wrapper PASS 00:06:59

@chaitanyaenr chaitanyaenr merged commit 1b5a3b0 into cloud-bulldozer:master Nov 19, 2020
@acalhounRH acalhounRH deleted the fix_util_path_resolution branch November 19, 2020 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyaenr chaitanyaenr chaitanyaenr approved these changes

@dry923 dry923 dry923 approved these changes

Assignees
No one assigned
Labels
ok to test Kick off our CI framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acalhounRH @dry923 @comet-perf-ci @chaitanyaenr