Uperf scale variables #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added fields for node id, density, and node count * pass variables all the way * add data as part of datapoitns * remove typo and redundant field * add fields from the cluster resource file * remove duplicate variable * add node and density range
smalleni
reviewed
Feb 8, 2021
jtaleric
reviewed
Feb 8, 2021
jtaleric
reviewed
Feb 8, 2021
jtaleric
reviewed
Feb 8, 2021
|
Also, can we squash? |
|
Usually you can squash merge, its a dropdown arrow inside the green commit button. |
yes! I have seen that glorious button! I actually have used it in the past too! for a simple change that doesn't seem to add a considerable amount of code, I thought a squash was simple... |
|
@jtaleric maybe I should rebase after making changes suggested here, hopefully the magic button will appear. |
* add fields from the cluster resource file
smalleni
requested changes
Feb 11, 2021
smalleni
approved these changes
Feb 11, 2021
smalleni
approved these changes
Feb 12, 2021
| "networkpolicy": self.networkpolicy | ||
| "networkpolicy": self.networkpolicy, | ||
| "density": int(self.pod_density), | ||
| "nodes_in_iter":int(self.nodes_in_iter), |
There was a problem hiding this comment.
this gives error as pod_density default value is ""
| @@ -54,6 +54,18 @@ def __init__(self, parent_parser): | |||
| self.args.num_pairs = os.getenv("num_pairs", "") | |||
| self.args.multus_client = os.getenv("multus_client", "") | |||
| self.args.networkpolicy = os.getenv("networkpolicy", "") | |||
| self.args.nodes_in_iter = os.getenv("node_count", "") | |||
| self.args.pod_density = os.getenv("pod_count", "") | |||
There was a problem hiding this comment.
initialize pod_count to default value 0 to avoid above type conversion error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the new variables from the uperf-scale enhancements to benchmark-operator. Since there are defaults provided in the python calls, I assume this change is not dependent on the forthcoming pr to benchmark operator. I am also planning on squash merging, as the intermediate commit messages are not always descriptive.