es_verify_cert is expected to be a lowercase string

[sarahbx]

I was going to open an issue with benchmark-operator, but I feel the fix belongs in the wrapper. After updating my local benchmark-operator repo, I have been unable to connect to my self-signed Elasticsearch instance.

Recently the Benchmark CRD elasticsearch.verify_cert field was set to a boolean. It was previously a string to support how the benchmark-wrapper handles it. Because of this, when verify_cert is set and added to templates, the string becomes capitalized during the python boolean to string conversion.

To fix this in the benchmark-operator, to make sure it always output a lowercase string can be fragile when there are so many templates to maintain and the ability to Bring-Your-Own-Workload.

Instead, I propose we make benchmark-wrapper more forgiving of env input, at a minimum converting the relevant input to lowercase.

[jtaleric]

LGTM!

[comet-perf-ci]

Can one of the admins verify this patch?

[rsevilla87]

Thanks for the PR @sarahbx , LGTM!