-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __init__.py to log_generator_wrapper #261
Add __init__.py to log_generator_wrapper #261
Conversation
Can one of the admins verify this patch? |
/rerun all |
Thanks @sarahbx I wonder if there could be a test added to avoid this situation? I am curious if it is how we test/build in containers vs VM? |
Results for SNAFU CI Test
|
@dry923 hmmm curious failure above. Seems test related not patch. |
@jtaleric @dry923 looks like..the CI checks for the last comment and picks the test name to run for it. In this case it was -> |
/rerun all |
Results for SNAFU CI Test
|
We are doing |
@amitsagtani97 @dry923 can someone run with @sarahbx patch manually? I highly doubt it breaks anything, but I want to double check. @sarahbx Testing for VM/CNV is obviously a gap for our CI. Is this something we can work together on to close? |
/rerun all |
It failed last time because the benchmark-operator PR for the log generator wasn't merged yet so it looked for a test that wasn't there yet. I just kicked it again. I suspect it will pass as adding init.py shouldn't break anything. |
Results for SNAFU CI Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
During VM testing, both @ebattat and I encountered
ModuleNotFoundError
forlog_generator_wrapper
Fixes
#254
log_generator_wrapper
subdirectory was missing__init__.py
file, preventing module import, adding.