Added functionality for creating and processing archive file #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@acalhounRH can you make it so the archive file location and possibly name can be set? |
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
from
e5fa327
to
c0de90f
Compare
|
Sure thing I used the --archive-file=<path to file/filename> and the user can provide a full path to file, it will default to cwd and user_cluster_uuid.archive. @dry923 python3.7 ~/git/benchmark-wrapper/snafu/run_snafu.py --tool sysbench -f /home/acalhoun/sysbench_results/example_cpu_test.conf --create-archive --archive-file ./alc-test.archive |
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
from
2269dc3
to
cddbad3
Compare
dry923
reviewed
May 27, 2021
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
2 times, most recently
from
220fb5f
to
d576e60
Compare
|
/rerun all |
jtaleric
reviewed
Jun 1, 2021
No testing within benchmark-wrapper, would this request be a follow on activity for benchmark-operator? |
|
@acalhounRH can you update the Readme for this as well? |
bah-humbug... |
|
Results for SNAFU CI Test
|
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
from
1352fe4
to
228e43d
Compare
dry923
reviewed
Jun 1, 2021
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
2 times, most recently
from
7322051
to
d7d70d3
Compare
dry923
reviewed
Jun 1, 2021
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
from
d28a13a
to
1ef1f69
Compare
|
Results for SNAFU CI Test
|
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
from
baddeb6
to
5ea73e9
Compare
dry923
approved these changes
Jun 2, 2021
|
Results for SNAFU CI Test
|
jtaleric
reviewed
Jun 2, 2021
README.md
Outdated
| Note: SNAFU does not depend upon Kubernetes, so you can use run_snafu.py on a bare-metal or VM cluster without relying | ||
| on Kubernetes to start/stop pods. So if you need your benchmark to collect data for both Kubernetes and non-Kubernetes | ||
| environments, develop in SNAFU and then write benchmark-operator benchmark to integrate with Kubernetes. | ||
| ** Why Should I use Benchmark-wrapper? ** |
There was a problem hiding this comment.
Did you expect some formatting like h2 with this?
There was a problem hiding this comment.
Was expecting Bold
acalhounRH
force-pushed
the
add_create_run_snafu_archive_output_file
branch
from
2095b8e
to
ff296a9
Compare
|
!!! Couldn't read commit file !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added functionality to create and re-index a archive file for benchmark-wrapper
when creating an archive we would just include --create-archive on any run and it will drop a
user_clustername_uuid.archivefile in the cwdfor example
python3.7 ~/git/benchmark-wrapper/snafu/run_snafu.py --tool sysbench -f /home/acalhoun/sysbench_results/example_cpu_test.conf --create-archivewhen indexing from an archive we would do,
run_snafu --tool archive --archive-file <file>. run_snafu will go straight to processing and indexing the listed ES friendly documents in the archive.For example
python3.7 ~/git/benchmark-wrapper/snafu/run_snafu.py --tool archive --archive-file myuser_mycluster_1b88311d-1230-409a-9ffa-94e6f9aa4754.archive -v@jtaleric @dry923
Fixes