Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps elasticsearch client version within our
setup.cfg
to useelasticsearch>=7.0.0,<8.0.0
, (as per documentation spec at https://elasticsearch-py.readthedocs.io/en/v7.14.0a1/), in order to enable Python 3.9 support. Joe and I discussed that we would need to test this change against our ES instances to make sure bumping the client version doesn't break our data ingest.Fixes
Currently we have elasticsearch client pinned as
elasticsearch>=6.0.0,<=7.0.2
, however these versions are not compatible with Python 3.9. The followingImportError
is observed when trying to invoke snafu on Python 3.9:Additionally, I removed the
elasticsearch1
module import, as we only have ES >= 7 in our environment, which is supported within the givenelasticsearch
module itself.