upgrade comparison patch

[mukrishn]

Description

This validation is not right, desired_version variable from here has got the old version prior to upgrade and validating with that cause the script to fail even after a successful upgrade. Instead it should compare with version post upgrade command.

2021-08-09T19:53:48Z - INFO     - MainProcess - trigger_upgrade: Cluster upgrade complete
...
2021-08-09T19:53:48Z - ERROR    - MainProcess - trigger_upgrade: Cluster did not upgrade to desired version
2021-08-09T19:53:48Z - ERROR    - MainProcess - trigger_upgrade: Cluster version is 4.7.16 and desired version is 4.7.13

Updated the var scope fixes it,

2021-08-10T18:04:19Z - INFO     - MainProcess - trigger_upgrade: Finished upgrading the cluster to version 4.7.13

Fixes

[codecov-commenter]

Codecov Report

Merging #321 (6c309a9) into master (8b69368) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #321   +/-   ##
=======================================
  Coverage   39.40%   39.40%           
=======================================
  Files          15       15           
  Lines         868      868           
=======================================
  Hits          342      342           
  Misses        526      526           

Flag	Coverage Δ
gha	39.40% <ø> (ø)
python-3.6	39.40% <ø> (ø)
unit	39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b69368...6c309a9. Read the comment docs.

[jtaleric]

/rerun all

[comet-perf-ci]

Results for SNAFU CI Test

Test	Result	Runtime
snafu/upgrade_openshift_wrapper	PASS	00:00:00

[comet-perf-ci]

Results for SNAFU CI Test

Test	Result	Runtime
snafu/upgrade_openshift_wrapper	PASS	00:00:00

[learnitall]

Left a few comments on the changes. Can you take a look and additionally do a run of pre-commit? Thanks!

[comet-perf-ci]

Results for SNAFU CI Test

Test	Result	Runtime
snafu/upgrade_openshift_wrapper	PASS	00:00:00

[comet-perf-ci]

Results for SNAFU CI Test

Test	Result	Runtime
snafu/upgrade_openshift_wrapper	PASS	00:00:00