-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs-drift touchup #343
fs-drift touchup #343
Conversation
Codecov Report
@@ Coverage Diff @@
## master #343 +/- ##
=======================================
Coverage 39.40% 39.40%
=======================================
Files 15 15
Lines 868 868
=======================================
Hits 342 342
Misses 526 526
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/rerun all |
Results for SNAFU CI Test
|
Ryan Drew said CI build system at the time had a problem, hence authorization problem for builds. Try again when this is fixed, then we should be good to merge. image build worked for me with podman. |
Hey @bengland2 I merged a fix into master. Can you update your branch with the latest changes from master and push here? The builds will retrigger automatically. |
@learnitall doing as you suggested... |
@learnitall it still fails, but perhaps for different reason? while installing scipy it blew up in numpy, something about requiring python > 3.7, but CI tests exercise python 3.6 thru python3.9. I don't know of a reason why we need to support python3.6, other than maybe testing on older OCP releases? What should I do about this? |
Results for SNAFU CI Test
|
@learnitall on second thought, it appears only the "arm64" tests failed. The amd64 ones worked. Perhaps arm support for numpy and scipy was limited in earlier python versions? If so, this has nothing to do with this PR so we should merge it, and perhaps skip arm64 tests for earlier python versions? |
Thanks for doing that @bengland2 . The arm64 builds are something that we are working towards, need to iron issues with python versions as you mentioned. Something I've got next on my TODO. I believe that your hypothesis is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
utilize common code from smallfile to record vfs stats
build without debug RPMs
log inputs