Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fs-drift touchup #343

Merged
merged 6 commits into from
Sep 13, 2021
Merged

Conversation

bengland2
Copy link
Contributor

utilize common code from smallfile to record vfs stats
build without debug RPMs
log inputs

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #343 (e8cf32d) into master (f599d52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   39.40%   39.40%           
=======================================
  Files          15       15           
  Lines         868      868           
=======================================
  Hits          342      342           
  Misses        526      526           
Flag Coverage Δ
gha 39.40% <ø> (ø)
python-3.6 39.40% <ø> (ø)
unit 39.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f599d52...e8cf32d. Read the comment docs.

@bengland2 bengland2 added the ok to test Kick off our CI framework label Sep 9, 2021
@bengland2
Copy link
Contributor Author

/rerun all

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fs_drift_wrapper PASS 00:04:04
snafu/smallfile_wrapper PASS 00:05:39

@bengland2
Copy link
Contributor Author

Ryan Drew said CI build system at the time had a problem, hence authorization problem for builds. Try again when this is fixed, then we should be good to merge. image build worked for me with podman.

@learnitall
Copy link
Collaborator

Hey @bengland2 I merged a fix into master. Can you update your branch with the latest changes from master and push here? The builds will retrigger automatically.

@bengland2
Copy link
Contributor Author

@learnitall doing as you suggested...

@bengland2
Copy link
Contributor Author

@learnitall it still fails, but perhaps for different reason? while installing scipy it blew up in numpy, something about requiring python > 3.7, but CI tests exercise python 3.6 thru python3.9. I don't know of a reason why we need to support python3.6, other than maybe testing on older OCP releases? What should I do about this?

@comet-perf-ci
Copy link
Collaborator

Results for SNAFU CI Test

Test Result Runtime
snafu/fs_drift_wrapper PASS 00:03:58
snafu/smallfile_wrapper PASS 00:05:17

@bengland2
Copy link
Contributor Author

@learnitall on second thought, it appears only the "arm64" tests failed. The amd64 ones worked. Perhaps arm support for numpy and scipy was limited in earlier python versions? If so, this has nothing to do with this PR so we should merge it, and perhaps skip arm64 tests for earlier python versions?

@learnitall
Copy link
Collaborator

Thanks for doing that @bengland2 . The arm64 builds are something that we are working towards, need to iron issues with python versions as you mentioned. Something I've got next on my TODO. I believe that your hypothesis is correct.

Copy link
Collaborator

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@learnitall learnitall merged commit 06ed1f1 into cloud-bulldozer:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok to test Kick off our CI framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants