Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coremark-pro #365

Merged
merged 3 commits into from
Nov 1, 2021
Merged

Add coremark-pro #365

merged 3 commits into from
Nov 1, 2021

Conversation

ewchong
Copy link
Contributor

@ewchong ewchong commented Oct 12, 2021 •
edited
Loading

Description

Added CoreMark-Pro support. See README.md for the details.

/cc @acalhounRH

@comet-perf-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@ewchong ewchong force-pushed the feature/coremark-pro branch 2 times, most recently from 8758189 to 4f87bda Compare October 15, 2021 15:28
@ewchong ewchong marked this pull request as ready for review October 15, 2021 15:29
@jtaleric jtaleric added enhancement New feature or request ok to test Kick off our CI framework labels Oct 15, 2021
jtaleric
jtaleric requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits and maybe a missing file?

@jtaleric jtaleric self-requested a review October 18, 2021 11:08
@codecov-commenter
Copy link

Codecov Report

Merging #365 (6188c13) into master (487ff98) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   39.40%   39.35%   -0.05%     
==========================================
  Files          15       15              
  Lines         868      869       +1     
==========================================
  Hits          342      342              
- Misses        526      527       +1
Flag Coverage Δ
gha 39.35% <ø> (-0.05%) ⬇️
python-3.6 39.35% <ø> (-0.05%) ⬇️
unit 39.35% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
snafu/utils/wrapper_factory.py 62.16% <0.00%> (-1.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487ff98...6188c13. Read the comment docs.

@ewchong
Copy link
Contributor Author

ewchong commented Oct 21, 2021

@jtaleric Not sure why the coverage changed when I didn't touch the file. Both of the CoreMark Pro images build. Anything else that needs to be addressed?

learnitall
learnitall requested changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a couple comments though that would be great if you could check out. Nothing major, just small deals that would be good to address.

snafu/benchmarks/coremarkpro/README.md Outdated Show resolved Hide resolved
snafu/benchmarks/coremarkpro/coremarkpro.py Outdated Show resolved Hide resolved
snafu/benchmarks/coremarkpro/coremarkpro.py Outdated Show resolved Hide resolved
snafu/benchmarks/coremarkpro/ci_test.sh Outdated Show resolved Hide resolved
ci/common.sh Outdated Show resolved Hide resolved
jtaleric
jtaleric approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@jtaleric jtaleric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ewchong ewchong requested a review from dry923 November 1, 2021 15:44
dry923
dry923 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@dry923 dry923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dry923 dry923 merged commit 710e806 into cloud-bulldozer:master Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtaleric jtaleric jtaleric approved these changes

@dry923 dry923 dry923 approved these changes

@learnitall learnitall Awaiting requested review from learnitall

Assignees
No one assigned
Labels
enhancement New feature or request ok to test Kick off our CI framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ewchong @comet-perf-ci @codecov-commenter @jtaleric @learnitall @dry923